-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add optional argument degree_of_freedom
for asymptotic_critical_value
#86
Conversation
Pull Request Test Coverage Report for Build 6223968781
💛 - Coveralls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we change the None defaults to 1 for the DOF?
@@ -91,7 +91,7 @@ def data(self, data: Union[dict, list]): | |||
If data is a list, it must be a list of length len(self.likelihood_names) + 1. | |||
|
|||
Raises: | |||
ValueError: If data is not a list of length len(self.likelihood_names) + 1. | |||
Warning: If data is not a list of length len(self.likelihood_names) + 1. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why warning and not error?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There will be no generate_values
in real data, so we will set a set of data
without generate_values
. This was introduced along with https://github.com/XENONnT/alea/pull/79/files#diff-ccb14fbc2f6819c7774476fe82d0c97563c7006391df64c86b0fbea0706af8f5R421 store_real_data
function.
I need to submit a new PR to solve the deprecated readthedocs configuration. https://readthedocs.org/projects/alea/builds/21954754/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @dachengx !
… to avoid mis-assign
Hey, @kdund . Sorry for the back-and-forth, I was validating the PR by non-beta study. I find that it is better to set So though the default value of |
Resolve: #83
What does the code in this PR do / what does it improve?
Add optional argument
degree_of_freedom
forasymptotic_critical_value
Can you briefly describe how it works?
asymptotic_dof
is provided as an__init__
argument, theStatisticalModel.asymptotic_dof
will be used in_confidence_interval_checks
.asymptotic_dof
is instatistical_model_args
, theRunner.confidence_interval_thresholds
will be set according toasymptotic_dof
, and further used in CL calculation.Can you give a minimal working example (or illustrate with a figure)?
What are the potential drawbacks of the codes?
When
"confidence_interval_kind"
is not"lower"
or"upper"
, anddegree_of_freedom
is notNone
or 1,asymptotic_critical_value
will raise an error.Please include the following if applicable: