Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

change folder/module name #9

Merged
merged 2 commits into from
Jun 15, 2023
Merged

change folder/module name #9

merged 2 commits into from
Jun 15, 2023

Conversation

kdund
Copy link
Collaborator

@kdund kdund commented Jun 15, 2023

No description provided.

@kdund kdund requested a review from hammannr June 15, 2023 21:18
@hammannr
Copy link
Collaborator

Great! Should we add a global find-and-replace of binference → alea?

@kdund kdund requested a review from dachengx June 15, 2023 21:25
@kdund
Copy link
Collaborator Author

kdund commented Jun 15, 2023

is there more?

@dachengx
Copy link
Collaborator

The 'binference' in README.md is unchanged, because people will completely change the README.md later.

kdund
kdund commented Jun 15, 2023
View reviewed changes
Copy link
Collaborator Author

@kdund kdund left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, thanks @dachengx !

@kdund kdund merged commit 99e21d9 into master Jun 15, 2023
@kdund kdund deleted the change_folder_name branch June 15, 2023 21:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dachengx dachengx dachengx approved these changes

@hammannr hammannr Awaiting requested review from hammannr

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kdund @hammannr @dachengx