Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use straxen documentation building functions to avoid duplicated codes #218

Merged
merged 5 commits into from
May 18, 2024

Conversation

dachengx
Copy link
Contributor

@dachengx dachengx commented May 15, 2024

Before you submit this PR: make sure to put all XENONnT specific information in a wiki-note as the repo is publicly accessible

Depends on XENONnT/straxen#1380

What does the code in this PR do / what does it improve?

Can you briefly describe how it works?

Can you give a minimal working example (or illustrate with a figure)?

Please include the following if applicable:

  • Update the docstring(s)
  • Bump plugin version(s)
  • Update the documentation
  • Tests to check the (new) code is working as desired.
  • Does it solve one of the GitHub open issues?

@dachengx dachengx marked this pull request as draft May 15, 2024 02:44
@dachengx dachengx force-pushed the use_straxen_docs_utils branch from fa6bb68 to 7393ff1 Compare May 15, 2024 02:48
@coveralls
Copy link

coveralls commented May 16, 2024

Pull Request Test Coverage Report for Build 9114118464

Details

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.007%) to 78.007%

Totals Coverage Status
Change from base Build 9109329114: 0.007%
Covered Lines: 2302
Relevant Lines: 2951

💛 - Coveralls

@dachengx dachengx marked this pull request as ready for review May 16, 2024 14:27
@dachengx dachengx requested a review from HenningSE May 16, 2024 15:55
@dachengx
Copy link
Contributor Author

Since this is rather trivial, let me merge it. :)

@dachengx dachengx merged commit 1080889 into main May 18, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants