Little bugfix for CSV generators

[ramirezdiego]

The trackid in Geant4 starts always at 1, so that parentid can be assigned to 0 for the primary particles. If we set both to 1, the get_parent function here gets confused and gives us a wrong NEST id for the evaluated interaction (hence we eventually reconstuct wrong energies along the simulation chain).

See screenshot before and after this change, in a context where clustering_method="lineage" and where gammas are simulated in our CSV input. Only the second case gives us the right lineage_type expected for these intereactions (NEST_id = 8; beta model):

In principle lineage clustering plays no role if we simulate single scatters, as is the case for the generators in this notebook, but this quick fix prevents confusing people when it becomes our default clustering method.

[coveralls]

Pull Request Test Coverage Report for Build 11387363334

Details

• 0 of 0 changed or added relevant lines in 0 files are covered.
• No unchanged relevant lines lost coverage.
• Overall coverage remained the same at 79.905%

---

Totals
Change from base Build 11365746591:	0.0%
Covered Lines:	2525
Relevant Lines:	3160

---

💛 - Coveralls

[HenningSE]

Thanks for the PR @ramirezdiego! As you mentioned, the lineage clustering can be a bit tricky with CSV input so one should always check if the algorithm works with the input instructions. For most cases, DBSCAN should give us the same results but the classification of clusters might differ a bit.