Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check if processed data already exists in --production mode #1024

Merged
merged 6 commits into from
May 16, 2022

Conversation

mflierm
Copy link
Contributor

@mflierm mflierm commented Apr 21, 2022

What does the code in this PR do / what does it improve?

The code checks in the runs database if the run that is being tried to process, has already been processed (i.e. bootstrax_status in ['done', 'processing', 'considering']). This avoids that the processing results in 'failed' (because there is no live_data available anymore).

Can you briefly describe how it works?

See above.

Can you give a minimal working example (or illustrate with a figure)?

Please include the following if applicable:

  • Update the docstring(s)
  • Update the documentation
  • Tests to check the (new) code is working as desired.
  • Does it solve one of the open issues on github?

Notes on testing

  • Until the automated tests pass, please mark the PR as a draft.
  • On the XENONnT fork we test with database access, on private forks there is no database access for security considerations.

@mflierm mflierm requested a review from JoranAngevaare April 21, 2022 07:12
Copy link
Contributor

@JoranAngevaare JoranAngevaare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Maricke, I think this is very useful (I at least screwed this up a couple of times)! Looks good. Let's make sure we test it once just before making the next release - just to be sure

bin/bootstrax Outdated Show resolved Hide resolved
bin/bootstrax Outdated Show resolved Hide resolved
Co-authored-by: Joran R. Angevaare <jorana@nikhef.nl>
@coveralls
Copy link

coveralls commented Apr 21, 2022

Coverage Status

Coverage increased (+0.01%) to 93.883% when pulling a4794ba on production_check into 55f1a43 on master.

Co-authored-by: Joran R. Angevaare <jorana@nikhef.nl>
Copy link
Contributor

@JoranAngevaare JoranAngevaare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot @mflierm - I'll merge it after we have done a final test!

@JoranAngevaare
Copy link
Contributor

Nice work Maricke!

@JoranAngevaare JoranAngevaare merged commit a13f6cf into master May 16, 2022
@JoranAngevaare JoranAngevaare deleted the production_check branch May 16, 2022 09:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Don't allow bootstrax --production for finished runs
3 participants