-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
URLConfig preprocessor #1110
URLConfig preprocessor #1110
Conversation
…straxen into url_config_preprocessor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jmosbacher , looks good. In #827 you had a few tests, can you re-use those examples again?
Should we make the format_url_kwargs
a default someday, or is xedocs already planned to use this feature?
Uhm, there are two self.format_url_kwargs
methods? L193, L325 🤔
Co-authored-by: Joran R. Angevaare <jorana@nikhef.nl>
Co-authored-by: Joran R. Angevaare <jorana@nikhef.nl>
Co-authored-by: Joran R. Angevaare <jorana@nikhef.nl>
…straxen into url_config_preprocessor
@JoranAngevaare hmm you are right, now i realize why i left it as a draft for so long. I never got around to finishing polishing it and adding tests... Ill do that now. |
@JoranAngevaare I added some tests and documentation |
Nice work Yossi, I added a test to assert I understand it well. Two final requests that I think would be useful for dummies like me:
|
Good idea. I added methods for the preprocessor as well as a |
@JoranAngevaare did you want to already add the autodoc feature to this PR before its merged? |
@jmosbacher let's do it in a seperate PR, nice work Yossi, thanks! |
A few small improvements to URLConfigs, similar to #827 but a bit simpler implementation.
validate
method that runs before the config is passed to the plugin.Preprocessors are passed the config and return a new/same config. They are applied in order of higher precedence first.