Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix bootstrax timeouts #1133

Merged
merged 3 commits into from
Jan 16, 2023
Merged

Fix bootstrax timeouts #1133

merged 3 commits into from
Jan 16, 2023

Conversation

JoranAngevaare
Copy link
Contributor

Small patch that allows supporting > 13 h long runs.

@coveralls
Copy link

coveralls commented Jan 16, 2023 •
edited
Loading

Coverage Status

Coverage: 93.563% (+0.06%) from 93.506% when pulling 2117ce9 on fix-bootstrax-timeouts into 68d56ba on master.

mflierm
mflierm reviewed Jan 16, 2023
View reviewed changes
Copy link
Contributor

@mflierm mflierm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Shouldn't there be an extra indent in lines 1506 and 1507?

@JoranAngevaare JoranAngevaare merged commit 39c563d into master Jan 16, 2023
@JoranAngevaare JoranAngevaare deleted the fix-bootstrax-timeouts branch January 16, 2023 14:45
@JoranAngevaare
Copy link
Contributor Author

@mflierm thanks, no the indents are fine (was one too many for some reason)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mflierm mflierm mflierm left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@JoranAngevaare @coveralls @mflierm