Bootstrax target removal after failures #1145
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improved bootstrax target removal after failures
This PR changes how we deal with bootstrax failures per plugin.
With this new detailed dictionary we scale more accordingly to plugin dependencies.
In the old version, paek_positions were unwillingly kept until the last iteration.
We want, for example, to keep producing peaklets if merged_s2s is failing (lately happening often, because of strax.ChunkCannotSplit).
If we failed twice we stop trying making events, four times we stop trying peak_basics etc.. and so on.
If we fail seven times, we just produce raw_record data.
We will also add peaklets to the list of targets passed as arguments to bootstrax.
To see the complete list of all the plugins that are produced at every iteretion, see this note.
Thanks @mflierm for helping 👍