Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use zstd as compressor of peaks #1154

Merged
merged 3 commits into from
Apr 19, 2023
Merged

Use zstd as compressor of peaks #1154

merged 3 commits into from
Apr 19, 2023

Conversation

dachengx
Copy link
Collaborator

@dachengx dachengx commented Apr 10, 2023

What does the code in this PR do / what does it improve?

Because sometimes peaks chunk is very large. And if so we will see error which was implemented in AxFoundation/strax#714.

Can you briefly describe how it works?

Can you give a minimal working example (or illustrate with a figure)?

Please include the following if applicable:

  • Update the docstring(s)
  • Update the documentation
  • Tests to check the (new) code is working as desired.
  • Does it solve one of the open issues on github?

Notes on testing

  • Until the automated tests pass, please mark the PR as a draft.
  • On the XENONnT fork we test with database access, on private forks there is no database access for security considerations.

All italic comments can be removed from this template.

Because sometimes peaks chunk is very large
@dachengx dachengx requested a review from cfuselli April 10, 2023 14:51
@coveralls
Copy link

coveralls commented Apr 10, 2023

Coverage Status

Coverage: 93.642% (+0.02%) from 93.618% when pulling de12af6 on peaks_zstd into f87d76a on master.

@dachengx dachengx merged commit ac83b61 into master Apr 19, 2023
@dachengx dachengx deleted the peaks_zstd branch April 19, 2023 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants