Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Save hits level information(hits height and time difference) in peak and event level #1155

Merged
merged 35 commits into from
May 3, 2023

Conversation

dachengx
Copy link
Collaborator

@dachengx dachengx commented Apr 13, 2023

Before you submit this PR: make sure to put all operations-related information in a wiki-note, a PR should be about code and is publicly accessible

This PR depends on AxFoundation/strax#716. The main plots are here.

What does the code in this PR do / what does it improve?

Can you briefly describe how it works?

Can you give a minimal working example (or illustrate with a figure)?

Please include the following if applicable:

  • Update the docstring(s)
  • Update the documentation
  • Tests to check the (new) code is working as desired.
  • Does it solve one of the open issues on github?

Notes on testing

  • Until the automated tests pass, please mark the PR as a draft.
  • On the XENONnT fork we test with database access, on private forks there is no database access for security considerations.

All italic comments can be removed from this template.

straxen/plugins/peaklets/peaklets.py Outdated Show resolved Hide resolved
straxen/plugins/peaklets/peaklets.py Outdated Show resolved Hide resolved
straxen/plugins/peaklets/peaklets.py Outdated Show resolved Hide resolved
@dachengx dachengx marked this pull request as ready for review May 1, 2023 12:34
@dachengx dachengx requested a review from shenyangshi May 1, 2023 20:33
@coveralls
Copy link

coveralls commented May 2, 2023

Coverage Status

Coverage: 93.469% (+0.05%) from 93.421% when pulling 185ae81 on hits_time_diff into ae2d3e0 on master.

@dachengx dachengx merged commit 9f71df5 into master May 3, 2023
@dachengx dachengx deleted the hits_time_diff branch May 3, 2023 03:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants