Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unnecessary check in merged_s2s #1195

Merged
merged 2 commits into from
Jun 10, 2023
Merged

Remove unnecessary check in merged_s2s #1195

merged 2 commits into from
Jun 10, 2023

Conversation

dachengx
Copy link
Collaborator

@dachengx dachengx commented Jun 7, 2023

Before you submit this PR: make sure to put all operations-related information in a wiki-note, a PR should be about code and is publicly accessible

What does the code in this PR do / what does it improve?

Sometimes end_merge_at and start_merge_at can be empty arrays. Function _filter_s1_starts has already guaranteed that the plugin will not merge a single peak.

Can you briefly describe how it works?

Can you give a minimal working example (or illustrate with a figure)?

Please include the following if applicable:

  • Update the docstring(s)
  • Update the documentation
  • Tests to check the (new) code is working as desired.
  • Does it solve one of the open issues on github?

Notes on testing

  • Until the automated tests pass, please mark the PR as a draft.
  • On the XENONnT fork we test with database access, on private forks there is no database access for security considerations.

All italic comments can be removed from this template.

@dachengx dachengx changed the title Remove unnecessary check inside merged_s2s Remove unnecessary check in merged_s2s Jun 7, 2023
@dachengx dachengx marked this pull request as ready for review June 10, 2023 18:21
@coveralls
Copy link

Coverage Status

coverage: 93.439% (-0.01%) from 93.451% when pulling f25a0e4 on rm_merged_s2s_check into 40f75b1 on master.

@dachengx dachengx merged commit f39d8ea into master Jun 10, 2023
@dachengx dachengx deleted the rm_merged_s2s_check branch June 10, 2023 18:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants