No longer test st.runs
in test_extract_latest_comment_lone_hits
#1199
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does the code in this PR do / what does it improve?
Fix straxen test according to strax's PR: AxFoundation/strax#727
Can you briefly describe how it works?
In AxFoundation/strax#727, after running
st.scan_runs
, there the returned dataframedsets
contains additionalavailable
(besides default and always storedpeak_basics
andraw_records
). Butst.runs
are not updated following the returned dataframedsets
, for faster performance.So in the test
test_extract_latest_comment_lone_hits
, we should refer todsets
but notst.runs
, to see ifavailable
really works.Can you give a minimal working example (or illustrate with a figure)?
Please include the following if applicable:
Notes on testing
All italic comments can be removed from this template.