Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No longer test st.runs in test_extract_latest_comment_lone_hits #1199

Merged
merged 1 commit into from
Jun 10, 2023

Conversation

dachengx
Copy link
Collaborator

@dachengx dachengx commented Jun 10, 2023

What does the code in this PR do / what does it improve?

Fix straxen test according to strax's PR: AxFoundation/strax#727

Can you briefly describe how it works?

In AxFoundation/strax#727, after running st.scan_runs, there the returned dataframe dsets contains additional available (besides default and always stored peak_basics and raw_records). But st.runs are not updated following the returned dataframe dsets, for faster performance.

So in the test test_extract_latest_comment_lone_hits, we should refer to dsets but not st.runs, to see if available really works.

Can you give a minimal working example (or illustrate with a figure)?

Please include the following if applicable:

  • Update the docstring(s)
  • Update the documentation
  • Tests to check the (new) code is working as desired.
  • Does it solve one of the open issues on github?

Notes on testing

  • Until the automated tests pass, please mark the PR as a draft.
  • On the XENONnT fork we test with database access, on private forks there is no database access for security considerations.

All italic comments can be removed from this template.

@dachengx dachengx marked this pull request as ready for review June 10, 2023 16:49
@dachengx dachengx merged commit 40f75b1 into master Jun 10, 2023
@dachengx dachengx deleted the fix_test_extract_latest_comment_lone_hits branch June 10, 2023 17:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant