Refactor nv plugins #1228
Refactor nv plugins #1228
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Remaining comments which cannot be posted as a review comment to avoid GitHub Rate Limit
pep8
straxen/plugins/events_nv/event_waveform_nv.py|94 col 1| W293 blank line contains whitespace
straxen/plugins/events_nv/events_nv.py|44 col 1| W293 blank line contains whitespace
straxen/plugins/events_nv/events_nv.py|63 col 1| W293 blank line contains whitespace
straxen/plugins/events_nv/events_nv.py|64 col 1| D102 Missing docstring in public method
straxen/plugins/events_nv/events_nv.py|71 col 9| WPS221 Found line with high Jones Complexity: 15 > 14
straxen/plugins/events_nv/events_nv.py|72 col 9| WPS362 Found assignment to a subscript slice
straxen/plugins/events_nv/events_nv.py|74 col 1| D102 Missing docstring in public method
straxen/plugins/events_nv/events_nv.py|80 col 84| W291 trailing whitespace
straxen/plugins/events_nv/events_nv.py|81 col 1| W293 blank line contains whitespace
straxen/plugins/events_nv/events_nv.py|93 col 1| W293 blank line contains whitespace
straxen/plugins/events_nv/events_nv.py|94 col 1| W293 blank line contains whitespace
straxen/plugins/events_nv/events_nv.py|101 col 21| E124 closing bracket does not match visual indentation
straxen/plugins/events_nv/events_nv.py|255 col 9| WPS221 Found line with high Jones Complexity: 15 > 14
|
Long time no news converting into draft. |
for more information, see https://pre-commit.ci
|
Tests can only pass once the strax PR is merged |
|
Changes unknown |
Refactor NV plugins:
Requires AxFoundation/strax#744 to be merged. After meging this PR we need to change the data types which are produced and shipped from the EBs. In addition, to hitlets, events_nv and event_positions_nv, event_wavefrom_nv must be made and shipped. The total amount of compressed data will be ~30 % smaller than before.