-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace z
from z_naive
to z_dv_corr
#1239
Conversation
Thanks Dacheng, I will try and process some event_info on a run just to make sure z = z_dv_corr then accept! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything looks good to me and I tested that both event_info
and event_positions
reflects these changes for run '053502'. The 'z' is consistent with 'z_dv_corr' now instead of 'z_naive'.
Another thing to check is the change of hash. If a PR changes fields or values of fields, the hash must be changed. The easiest way to change the hash is to change the |
Ah yup, the hash has been changed as well, sorry, I forgot to mention that. |
What does the code in this PR do / what does it improve?
It replaces
z
toz_dv_corr
,alt_s1_z
toalt_s1_z_dv_corr
andalt_s2_z
toalt_s2_z_dv_corr
. Becausez_dv_corr
already played a good correction forz
.Reference: https://xe1t-wiki.lngs.infn.it/doku.php?id=xenon:xenonnt:terliuk:drift_field_z_bias_correction
Can you briefly describe how it works?
Can you give a minimal working example (or illustrate with a figure)?
Please include the following if applicable:
Notes on testing
All italic comments can be removed from this template.