New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make some plugins and play with the dependency so that we can track them #1272

Merged

JYangQi00 merged 1 commit into test_plugin_changes from track_lineage_changes

Sep 29, 2023

Contributor

JYangQi00 commented Sep 29, 2023

Before you submit this PR: make sure to put all operations-related information in a wiki-note, a PR should be about code and is publicly accessible

What does the code in this PR do / what does it improve?

Can you briefly describe how it works?

Can you give a minimal working example (or illustrate with a figure)?

Please include the following if applicable:

Update the docstring(s)
Update the documentation
Tests to check the (new) code is working as desired.
Does it solve one of the open issues on github?

Notes on testing

Until the automated tests pass, please mark the PR as a draft.
On the XENONnT fork we test with database access, on private forks there is no database access for security considerations.

All italic comments can be removed from this template.


          Make some plugins and play with the dependency so that we can track them

b0624d7

JYangQi00 merged commit b92440f into test_plugin_changes

1 of 7 checks passed

github-actions bot reviewed

View reviewed changes

github-actions bot left a comment

Remaining comments which cannot be posted as a review comment to avoid GitHub Rate Limit

pep8

straxen/plugins/events/event_s2_fwhm.py|11 col 71| W291 trailing whitespace
straxen/plugins/events/event_s2_fwhm.py|16 col 1| W293 blank line contains whitespace
straxen/plugins/events/event_s2_fwhm.py|22 col 37| E127 continuation line over-indented for visual indent
straxen/plugins/events/event_s2_fwhm.py|24 col 63| E241 multiple spaces after ','
straxen/plugins/events/event_s2_fwhm.py|26 col 1| W293 blank line contains whitespace
straxen/plugins/events/event_s2_fwhm.py|29 col 1| D102 Missing docstring in public method
straxen/plugins/events/event_s2_fwhm.py|37 col 1| W293 blank line contains whitespace
straxen/plugins/events/event_s2_fwhm.py|38 col 1| D102 Missing docstring in public method
straxen/plugins/events/event_s2_fwhm.py|38 col 38| W291 trailing whitespace
straxen/plugins/events/event_s2_fwhm.py|43 col 12| WPS507 Found useless len() compare
straxen/plugins/events/event_s2_fwhm.py|43 col 23| E225 missing whitespace around operator
straxen/plugins/events/event_s2_fwhm.py|45 col 13| WPS221 Found line with high Jones Complexity: 25 > 14
straxen/plugins/events/event_s2_fwhm.py|45 col 54| E231 missing whitespace after ','
straxen/plugins/events/event_s2_fwhm.py|45 col 101| E501 line too long (104 > 100 characters)
straxen/plugins/events/event_s2_fwhm.py|46 col 13| WPS221 Found line with high Jones Complexity: 16 > 14
straxen/plugins/events/event_s2_fwhm.py|47 col 1| W293 blank line contains whitespace
straxen/plugins/events/event_s2_fwhm.py|50 col 21| WPS221 Found line with high Jones Complexity: 16 > 14
straxen/plugins/events/event_s2_fwhm.py|51 col 21| WPS221 Found line with high Jones Complexity: 16 > 14
straxen/plugins/events/event_s2_fwhm.py|52 col 1| W293 blank line contains whitespace
straxen/plugins/events/event_s2_fwhm.py|53 col 1| W293 blank line contains whitespace
straxen/plugins/events/event_s2_fwhm.py|54 col 13| E303 too many blank lines (2)
straxen/plugins/events/event_s2_fwhm.py|57 col 17| WPS221 Found line with high Jones Complexity: 15 > 14
straxen/plugins/events/event_s2_fwhm.py|58 col 1| W293 blank line contains whitespace
straxen/plugins/events/event_s2_fwhm.py|60 col 1| W293 blank line contains whitespace
straxen/plugins/events/event_s2_fwhm.py|61 col 1| E302 expected 2 blank lines, found 1
straxen/plugins/events/event_s2_fwhm.py|62 col 1| D103 Missing docstring in public function
straxen/plugins/events/event_s2_fwhm.py|68 col 13| WPS221 Found line with high Jones Complexity: 15 > 14
straxen/plugins/events/event_s2_fwhm.py|68 col 36| E225 missing whitespace around operator
straxen/plugins/events/event_s2_fwhm.py|71 col 1| W293 blank line contains whitespace
straxen/plugins/events/event_s2_fwhm.py|72 col 1| E302 expected 2 blank lines, found 1
straxen/plugins/events/event_s2_fwhm.py|73 col 1| D103 Missing docstring in public function
straxen/plugins/events/event_s2_fwhm.py|73 col 29| E202 whitespace before ')'
straxen/plugins/events/event_s2_fwhm.py|74 col 5| WPS221 Found line with high Jones Complexity: 21 > 14
straxen/plugins/events/event_s2_fwhm.py|74 col 40| E231 missing whitespace after ','
straxen/plugins/events/event_s2_fwhm.py|76 col 17| E225 missing whitespace around operator
straxen/plugins/events/event_s2_fwhm.py|78 col 1| W293 blank line contains whitespace
straxen/plugins/events/event_s2_fwhm.py|79 col 22| W292 no newline at end of file

straxen/plugins/events/__init__.py

@@ @@ -66,3 +66,10 @@ @@
               from . import multi_scatter
               from .multi_scatter import *
+              #Only for testing!

github-actions bot Sep 29, 2023

[pep8] _{reported by reviewdog 🐶}
E265 block comment should start with '# '

straxen/plugins/events/__init__.py

@@ @@ -66,3 +66,10 @@ @@
               from . import multi_scatter
               from .multi_scatter import *
+              #Only for testing!
+              from . import event_s2_fwhm

github-actions bot Sep 29, 2023

[pep8] _{reported by reviewdog 🐶}
F401 '.event_s2_fwhm' imported but unused

straxen/plugins/events/__init__.py

+              #Only for testing!
+              from . import event_s2_fwhm
+              from .event_s2_fwhm import *

github-actions bot Sep 29, 2023

[pep8] _{reported by reviewdog 🐶}
F401 '.event_s2_fwhm.*' imported but unused

straxen/plugins/events/__init__.py

+              #Only for testing!
+              from . import event_s2_fwhm
+              from .event_s2_fwhm import *

github-actions bot Sep 29, 2023

[pep8] _{reported by reviewdog 🐶}
WPS347 Found vague import that may cause confusion: *

straxen/plugins/events/__init__.py

+              #Only for testing!
+              from . import event_s2_fwhm
+              from .event_s2_fwhm import *

github-actions bot Sep 29, 2023

[pep8] _{reported by reviewdog 🐶}
WPS458 Found imports collision: event_s2_fwhm

straxen/plugins/events/event_positions.py

@@ @@ -17,7 +17,7 @@ class EventPositions(strax.Plugin): @@
                   should be given as (x, y, z), not (x, y, drift_time).
                   """
-                  depends_on = ('event_basics',)
+                  depends_on = ('event_basics','event_nans')

github-actions bot Sep 29, 2023

[pep8] _{reported by reviewdog 🐶}
E231 missing whitespace after ','

straxen/plugins/events/event_positions.py

		@@ -100,6 +100,9 @@ def infer_dtype(self):
		f'Alternative S{s_i} (rel. main S{3 - s_i}) interaction angular position (radians)')]

		dtype += [('theta', np.float32, f'Main interaction angular position (radians)')]

github-actions bot Sep 29, 2023

[pep8] _{reported by reviewdog 🐶}
W293 blank line contains whitespace

straxen/plugins/events/event_positions.py

@@ @@ -100,6 +100,9 @@ def infer_dtype(self): @@
                                      f'Alternative S{s_i} (rel. main S{3 - s_i}) interaction angular position (radians)')]
                       dtype += [('theta', np.float32, f'Main interaction angular position (radians)')]
+                      #Add that random nan field just for testing, but don't do anything with it

github-actions bot Sep 29, 2023

[pep8] _{reported by reviewdog 🐶}
E265 block comment should start with '# '

straxen/plugins/events/event_s2_fwhm.py


		export, __all__ = strax.exporter()

		@export

github-actions bot Sep 29, 2023

[pep8] _{reported by reviewdog 🐶}
E302 expected 2 blank lines, found 1

straxen/plugins/events/event_s2_fwhm.py

+              @export
+              class S2FWHM(strax.Plugin):
+                  """

github-actions bot Sep 29, 2023

[pep8] _{reported by reviewdog 🐶}
D204 1 blank line required after class docstring

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet