Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add kwargs to simulation context #1277

Merged
merged 6 commits into from
Dec 19, 2023
Merged

add kwargs to simulation context #1277

merged 6 commits into from
Dec 19, 2023

Conversation

LuisSanchez25
Copy link
Contributor

Before you submit this PR: make sure to put all operations-related information in a wiki-note, a PR should be about code and is publicly accessible

What does the code in this PR do / what does it improve?

Add kwargs argument to the offline simulation context.

Can you briefly describe how it works?

Can you give a minimal working example (or illustrate with a figure)?

Please include the following if applicable:

  • Update the docstring(s)
  • Update the documentation
  • Tests to check the (new) code is working as desired.
  • Does it solve one of the open issues on github?

Notes on testing

  • Until the automated tests pass, please mark the PR as a draft.
  • On the XENONnT fork we test with database access, on private forks there is no database access for security considerations.

All italic comments can be removed from this template.

@coveralls
Copy link

coveralls commented Oct 3, 2023

Coverage Status

coverage: 91.76% (-0.01%) from 91.77%
when pulling c4e71ed on kwargs_sim_context
into c532353 on master.

@LuisSanchez25 LuisSanchez25 marked this pull request as ready for review October 4, 2023 01:05
shenyangshi
shenyangshi previously approved these changes Oct 9, 2023
Copy link
Contributor

@shenyangshi shenyangshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks :)

Copy link
Collaborator

@dachengx dachengx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @LuisSanchez25 .

@dachengx dachengx merged commit bad445f into master Dec 19, 2023
9 checks passed
@dachengx dachengx deleted the kwargs_sim_context branch December 19, 2023 21:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants