Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add gps plugins #1285

Merged
merged 9 commits into from
Dec 18, 2023
Merged

Add gps plugins #1285

merged 9 commits into from
Dec 18, 2023

Conversation

WenzDaniel
Copy link
Collaborator

What does the code in this PR do / what does it improve?

Removed old syncing plugins and move GPS plugins from cutax to straxen.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remaining comments which cannot be posted as a review comment to avoid GitHub Rate Limit

pep8

straxen/plugins/gps_syncing/gps_syncing.py|43 col 102| C812 missing trailing comma
straxen/plugins/gps_syncing/gps_syncing.py|47 col 1| W293 blank line contains whitespace
straxen/plugins/gps_syncing/gps_syncing.py|48 col 1| D102 Missing docstring in public method
straxen/plugins/gps_syncing/gps_syncing.py|49 col 74| W291 trailing whitespace
straxen/plugins/gps_syncing/gps_syncing.py|52 col 1| W293 blank line contains whitespace
straxen/plugins/gps_syncing/gps_syncing.py|53 col 1| D102 Missing docstring in public method
straxen/plugins/gps_syncing/gps_syncing.py|54 col 9| E265 block comment should start with '# '
straxen/plugins/gps_syncing/gps_syncing.py|59 col 1| W293 blank line contains whitespace
straxen/plugins/gps_syncing/gps_syncing.py|60 col 1| W293 blank line contains whitespace
straxen/plugins/gps_syncing/gps_syncing.py|61 col 5| E303 too many blank lines (2)
straxen/plugins/gps_syncing/gps_syncing.py|62 col 71| W291 trailing whitespace
straxen/plugins/gps_syncing/gps_syncing.py|66 col 9| WPS221 Found line with high Jones Complexity: 19 > 14
straxen/plugins/gps_syncing/gps_syncing.py|70 col 9| WPS473 Found too many empty lines in def: 7 > 6
straxen/plugins/gps_syncing/gps_syncing.py|71 col 71| W291 trailing whitespace
straxen/plugins/gps_syncing/gps_syncing.py|84 col 16| WPS508 Found incorrect not with compare usage
straxen/plugins/gps_syncing/gps_syncing.py|84 col 35| WPS323 Found % string formatting
straxen/plugins/gps_syncing/gps_syncing.py|84 col 85| E228 missing whitespace around modulo operator
straxen/plugins/gps_syncing/gps_syncing.py|89 col 9| WPS221 Found line with high Jones Complexity: 15 > 14
straxen/plugins/gps_syncing/gps_syncing.py|89 col 30| E201 whitespace after '{'
straxen/plugins/gps_syncing/gps_syncing.py|89 col 86| E202 whitespace before '}'
straxen/plugins/gps_syncing/gps_syncing.py|92 col 1| W293 blank line contains whitespace
straxen/plugins/gps_syncing/gps_syncing.py|95 col 72| W291 trailing whitespace
straxen/plugins/gps_syncing/gps_syncing.py|98 col 1| W293 blank line contains whitespace
straxen/plugins/gps_syncing/gps_syncing.py|106 col 9| WPS121 Found usage of a variable marked as unused: _gps_pulses
straxen/plugins/gps_syncing/gps_syncing.py|107 col 9| WPS121 Found usage of a variable marked as unused: _gps_pulses
straxen/plugins/gps_syncing/gps_syncing.py|110 col 9| WPS121 Found usage of a variable marked as unused: _gps_truth
straxen/plugins/gps_syncing/gps_syncing.py|111 col 9| WPS121 Found usage of a variable marked as unused: _gps_truth
straxen/plugins/gps_syncing/gps_syncing.py|113 col 57| WPS121 Found usage of a variable marked as unused: _gps_truth
straxen/plugins/gps_syncing/gps_syncing.py|113 col 69| WPS121 Found usage of a variable marked as unused: _gps_pulses
straxen/plugins/gps_syncing/gps_syncing.py|123 col 68| W291 trailing whitespace
straxen/plugins/gps_syncing/gps_syncing.py|125 col 1| W293 blank line contains whitespace
straxen/plugins/gps_syncing/gps_syncing.py|131 col 36| WPS507 Found useless len() compare
straxen/plugins/gps_syncing/gps_syncing.py|131 col 56| W291 trailing whitespace
straxen/plugins/gps_syncing/gps_syncing.py|132 col 36| W503 line break before binary operator
straxen/plugins/gps_syncing/gps_syncing.py|132 col 39| WPS507 Found useless len() compare
straxen/plugins/gps_syncing/gps_syncing.py|133 col 35| W503 line break before binary operator
straxen/plugins/gps_syncing/gps_syncing.py|134 col 12| WPS121 Found usage of a variable marked as unused: _has_no_gps_but_events
straxen/plugins/gps_syncing/gps_syncing.py|139 col 1| W293 blank line contains whitespace
straxen/plugins/gps_syncing/gps_syncing.py|140 col 25| E272 multiple spaces before keyword
straxen/plugins/gps_syncing/gps_syncing.py|140 col 25| E222 multiple spaces after operator
straxen/plugins/gps_syncing/gps_syncing.py|141 col 12| WPS121 Found usage of a variable marked as unused: _has_no_events
straxen/plugins/gps_syncing/gps_syncing.py|143 col 1| W293 blank line contains whitespace
straxen/plugins/gps_syncing/gps_syncing.py|145 col 68| W291 trailing whitespace
straxen/plugins/gps_syncing/gps_syncing.py|148 col 1| W293 blank line contains whitespace
straxen/plugins/gps_syncing/gps_syncing.py|149 col 21| E222 multiple spaces after operator
straxen/plugins/gps_syncing/gps_syncing.py|149 col 58| W291 trailing whitespace
straxen/plugins/gps_syncing/gps_syncing.py|154 col 31| E124 closing bracket does not match visual indentation
straxen/plugins/gps_syncing/gps_syncing.py|156 col 1| W293 blank line contains whitespace
straxen/plugins/gps_syncing/gps_syncing.py|160 col 1| W293 blank line contains whitespace
straxen/plugins/gps_syncing/gps_syncing.py|161 col 1| W293 blank line contains whitespace
straxen/plugins/gps_syncing/gps_syncing.py|162 col 1| D102 Missing docstring in public method
straxen/plugins/gps_syncing/gps_syncing.py|162 col 5| E303 too many blank lines (2)
straxen/plugins/gps_syncing/gps_syncing.py|166 col 1| W293 blank line contains whitespace
straxen/plugins/gps_syncing/gps_syncing.py|167 col 1| W293 blank line contains whitespace
straxen/plugins/gps_syncing/gps_syncing.py|168 col 1| D102 Missing docstring in public method
straxen/plugins/gps_syncing/gps_syncing.py|168 col 5| WPS615 Found unpythonic getter or setter
straxen/plugins/gps_syncing/gps_syncing.py|168 col 5| E303 too many blank lines (2)
straxen/plugins/gps_syncing/gps_syncing.py|172 col 25| WPS121 Found usage of a variable marked as unused: _delay
straxen/plugins/gps_syncing/gps_syncing.py|174 col 1| W293 blank line contains whitespace
straxen/plugins/gps_syncing/gps_syncing.py|175 col 1| D102 Missing docstring in public method
straxen/plugins/gps_syncing/gps_syncing.py|175 col 43| W291 trailing whitespace
straxen/plugins/gps_syncing/gps_syncing.py|182 col 1| W293 blank line contains whitespace
straxen/plugins/gps_syncing/gps_syncing.py|183 col 9| E303 too many blank lines (2)
straxen/plugins/gps_syncing/gps_syncing.py|186 col 48| E222 multiple spaces after operator
straxen/plugins/gps_syncing/gps_syncing.py|192 col 15| C408 Unnecessary dict call - rewrite as a literal.
straxen/plugins/gps_syncing/gps_syncing.py|200 col 8| N801 class name 'GpsSync_nv' should use CapWords convention
straxen/plugins/gps_syncing/gps_syncing.py|201 col 1| D200 One-line docstring should fit on one line with quotes
straxen/plugins/gps_syncing/gps_syncing.py|201 col 50| W291 trailing whitespace
straxen/plugins/gps_syncing/gps_syncing.py|203 col 1| W293 blank line contains whitespace
straxen/plugins/gps_syncing/gps_syncing.py|208 col 63| C812 missing trailing comma
straxen/plugins/gps_syncing/gps_syncing.py|215 col 57| C812 missing trailing comma
straxen/plugins/gps_syncing/gps_syncing.py|222 col 1| W293 blank line contains whitespace
straxen/plugins/gps_syncing/gps_syncing.py|225 col 1| W293 blank line contains whitespace
straxen/plugins/gps_syncing/gps_syncing.py|227 col 1| W293 blank line contains whitespace
straxen/plugins/gps_syncing/gps_syncing.py|228 col 1| D102 Missing docstring in public method
straxen/plugins/gps_syncing/gps_syncing.py|228 col 5| WPS612 Found useless overwritten method: setup
straxen/plugins/gps_syncing/gps_syncing.py|230 col 1| W293 blank line contains whitespace
straxen/plugins/gps_syncing/gps_syncing.py|232 col 1| D102 Missing docstring in public method
straxen/plugins/gps_syncing/gps_syncing.py|237 col 1| W293 blank line contains whitespace
straxen/plugins/gps_syncing/gps_syncing.py|238 col 1| D102 Missing docstring in public method
straxen/plugins/gps_syncing/gps_syncing.py|241 col 43| WPS121 Found usage of a variable marked as unused: _mask_nveto
straxen/plugins/gps_syncing/gps_syncing.py|246 col 13| WPS121 Found usage of a variable marked as unused: _mask_nveto
straxen/plugins/gps_syncing/gps_syncing.py|248 col 29| WPS121 Found usage of a variable marked as unused: _mask_nveto
straxen/plugins/gps_syncing/gps_syncing.py|250 col 1| W293 blank line contains whitespace
straxen/plugins/gps_syncing/gps_syncing.py|257 col 1| W293 blank line contains whitespace
straxen/plugins/gps_syncing/gps_syncing.py|258 col 1| W293 blank line contains whitespace
straxen/plugins/gps_syncing/gps_syncing.py|259 col 8| N801 class name 'GpsSync_mv' should use CapWords convention
straxen/plugins/gps_syncing/gps_syncing.py|260 col 1| D200 One-line docstring should fit on one line with quotes
straxen/plugins/gps_syncing/gps_syncing.py|260 col 1| D204 1 blank line required after class docstring
straxen/plugins/gps_syncing/gps_syncing.py|260 col 50| W291 trailing whitespace
straxen/plugins/gps_syncing/gps_syncing.py|266 col 63| C812 missing trailing comma
straxen/plugins/gps_syncing/gps_syncing.py|273 col 1| W293 blank line contains whitespace
straxen/plugins/gps_syncing/gps_syncing.py|276 col 1| W293 blank line contains whitespace
straxen/plugins/gps_syncing/gps_syncing.py|278 col 1| W293 blank line contains whitespace
straxen/plugins/gps_syncing/gps_syncing.py|279 col 1| D102 Missing docstring in public method
straxen/plugins/gps_syncing/gps_syncing.py|279 col 5| WPS612 Found useless overwritten method: setup
straxen/plugins/gps_syncing/gps_syncing.py|281 col 1| W293 blank line contains whitespace
straxen/plugins/gps_syncing/gps_syncing.py|283 col 1| D102 Missing docstring in public method
straxen/plugins/gps_syncing/gps_syncing.py|288 col 1| W293 blank line contains whitespace
straxen/plugins/gps_syncing/gps_syncing.py|289 col 1| D102 Missing docstring in public method
straxen/plugins/gps_syncing/gps_syncing.py|292 col 43| WPS121 Found usage of a variable marked as unused: _mask_nveto
straxen/plugins/gps_syncing/gps_syncing.py|293 col 1| W293 blank line contains whitespace

straxen/plugins/__init__.py Show resolved Hide resolved
straxen/plugins/__init__.py Show resolved Hide resolved
straxen/plugins/__init__.py Show resolved Hide resolved
straxen/plugins/__init__.py Show resolved Hide resolved
straxen/plugins/gps_syncing/__init__.py Show resolved Hide resolved
straxen/plugins/gps_syncing/gps_syncing.py Outdated Show resolved Hide resolved
straxen/plugins/gps_syncing/gps_syncing.py Outdated Show resolved Hide resolved
straxen/plugins/gps_syncing/gps_syncing.py Outdated Show resolved Hide resolved
straxen/plugins/gps_syncing/gps_syncing.py Outdated Show resolved Hide resolved
straxen/plugins/gps_syncing/gps_syncing.py Outdated Show resolved Hide resolved
@WenzDaniel
Copy link
Collaborator Author

I can fix the reviewdoc things, but not sure if I should wait for the pre-commit thing.

@WenzDaniel
Copy link
Collaborator Author

To make tests working we need to updated our test data to a run for which also GPS signals are available:

nt_test_run_id = '012882'
@export
def download_test_data(test_data='https://raw.githubusercontent.com/XENONnT/strax_auxiliary_files/353b2c60a01e96f67e4ba544ce284bd91241964d/strax_files/strax_test_data_straxv1.1.0.tar', # noqa
):

This should to be discussed in Team A.

@WenzDaniel WenzDaniel marked this pull request as draft November 22, 2023 07:33
@WenzDaniel WenzDaniel marked this pull request as ready for review December 14, 2023 12:09
@coveralls
Copy link

coveralls commented Dec 14, 2023

Coverage Status

coverage: 91.786% (-1.0%) from 92.822%
when pulling 72e992d on add_gps_plugins
into f23319d on master.

@FaroutYLq FaroutYLq requested a review from jjakob03 December 14, 2023 17:18
@WenzDaniel
Copy link
Collaborator Author

The failing test has something to do with a numerical issue in the event pattern fit which cannot be solved right now.

jjakob03
jjakob03 previously approved these changes Dec 18, 2023
Copy link
Contributor

@jjakob03 jjakob03 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I did not check mv but nv works :)

straxen/plugins/gps_syncing/gps_syncing.py Outdated Show resolved Hide resolved
Co-authored-by: Johanna Jakob <56300925+jjakob03@users.noreply.github.com>
@WenzDaniel
Copy link
Collaborator Author

Thanks Johanna, the MV plugins were just copied over from cutax. I will try to verify them again.

@WenzDaniel WenzDaniel merged commit 540d840 into master Dec 18, 2023
9 checks passed
@WenzDaniel WenzDaniel deleted the add_gps_plugins branch December 18, 2023 13:56
@dachengx dachengx mentioned this pull request Aug 26, 2024
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants