Report PR changes phase B #1294
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r_changes_phase_b
JYangQi00
reviewed
Nov 27, 2023
| if [ "$#" -ne 4 ]; then | ||
| echo "Usage: $0 <first_branch_name> <second_branch_name> <output folder path> <run_id>" | ||
| if [ "$#" -ne 2 ]; then | ||
| echo "Usage: $0 <first_branch_name> <second_branch_name>" |
There was a problem hiding this comment.
Presumably all of the files generated from this script are just saved in the current directory, correct?
There was a problem hiding this comment.
Yes, currently yes.
JYangQi00
reviewed
Nov 27, 2023
| ./report_pr_changes --branch new --computation changed_affected_plugin | ||
| git checkout $old_branch | ||
| ./report_pr_changes --branch old --computation changed_affected_plugin | ||
| ./report_pr_changes --branch old --computation report_changes |
There was a problem hiding this comment.
Does the cleanup function automatically delete all of the temporary json files that we've made?
There was a problem hiding this comment.
No, I have not deleted them. Maybe should delete it by python scripts. Because they are generated by the python scripts.
JYangQi00
reviewed
Nov 27, 2023
| @@ -0,0 +1,203 @@ | |||
| #!/usr/bin/env python | |||
There was a problem hiding this comment.
Thanks for organizing the code! I really appreciate it. Shall I comment these functions?
JYangQi00
reviewed
Nov 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Organize codes into python script but there is no functionality changed.