change integration window #1303
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey Mariana, can you please add more information in the PR description? For bookkeeping |
|
Maybe we should also update the plugin version? |
|
Can we merge this now or should we wait @dachengx @JYangQi00 ? |
|
I think we can proceed since this affects only led_calibration data and nothing else. Namely, the lineage of what ever is above records won't be touched |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does the code in this PR do / what does it improve?
The updated code changes the integration window from [78, 116] to [78, 132] ADC
Can you briefly describe how it works?
This is the ADC window in which the waveform is expected to appear during an LED calibration. This change was necessary because the previous window did not contain the whole waveform (see this note)