Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

_text_formats should include txt but not text #1324

Merged
merged 2 commits into from
Feb 15, 2024
Merged

Conversation

dachengx
Copy link
Collaborator

@dachengx dachengx commented Jan 21, 2024

What does the code in this PR do / what does it improve?

When judging whether the file is a text file in resource_from_url, the text file should end with txt but not text.

is_binary = fmt not in _text_formats

Can you briefly describe how it works?

Can you give a minimal working example (or illustrate with a figure)?

@coveralls
Copy link

coveralls commented Jan 21, 2024

Coverage Status

coverage: 91.337% (+0.02%) from 91.316%
when pulling 64ead4e on update_text_formats
into b18e8f3 on master.

@dachengx dachengx marked this pull request as ready for review January 22, 2024 07:03
@dachengx dachengx requested a review from WenzDaniel January 22, 2024 07:04
@dachengx dachengx requested review from yuema137 and removed request for WenzDaniel February 11, 2024 03:55
@yuema137
Copy link
Collaborator

It's a straightforward fix. Thanks

@dachengx dachengx merged commit 2cc3473 into master Feb 15, 2024
8 checks passed
@dachengx dachengx deleted the update_text_formats branch February 15, 2024 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants