Online veto intervals fix #1331
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does the code in this PR do / what does it improve?
A dedicated
veto_intervalsplugin for the online monitor is proposed. This is because sometimes at high rate calibrations, all processing fails just because the veto intervals can not be inserted in the MongoDB (max size 16MB).Can you briefly describe how it works?
If the original
veto_intervalschunk exceeds a certain size, the data is randomly sampled. To keep the cumulative deadtime info, an extra dtype is added that takes the cumulative deadtime from the original veto_intervals, but only the random indices are kept (this gives the same total cumulative deadtime). To avoid the database to overload after all again, the same random sampling is done if the new data array would exceed 10MB.p.s. commit c5e89bb was made by me (@mflierm), not by Joran (historical reasons).