Fix numerical comparison error of test_patternfit_stats
#1334
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey Dacheng, thank you for fixing the test! I am surprised, though; I never see it fail |
GiovanniVolta
approved these changes
Feb 16, 2024
It is a very rare corner case. :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does the code in this PR do / what does it improve?
An error is seen in test: https://github.com/XENONnT/straxen/actions/runs/7918467685/job/21616952222, from a numerical comparison
assert (1.0000000000000002 >= 0 & 1.0000000000000002 <= 1).Can you briefly describe how it works?
This PR uses
math.isclosein the test to solve the error. When1.0000000000000002is close to1.0, the argument ofassertis still true.Can you give a minimal working example (or illustrate with a figure)?
Please include the following if applicable: