Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove xnt_simulation_config #1366

Merged
merged 1 commit into from
Apr 21, 2024
Merged

Remove xnt_simulation_config #1366

merged 1 commit into from
Apr 21, 2024

Conversation

dachengx
Copy link
Collaborator

Before you submit this PR: make sure to put all operations-related information in a wiki-note, a PR should be about code and is publicly accessible

What does the code in this PR do / what does it improve?

Because it is not used

Can you briefly describe how it works?

Can you give a minimal working example (or illustrate with a figure)?

Please include the following if applicable:

  • Update the docstring(s)
  • Update the documentation
  • Tests to check the (new) code is working as desired.
  • Does it solve one of the open issues on github?

Notes on testing

  • Until the automated tests pass, please mark the PR as a draft.
  • On the XENONnT fork we test with database access, on private forks there is no database access for security considerations.

All italic comments can be removed from this template.

@dachengx dachengx requested a review from yuema137 April 21, 2024 13:51
@coveralls
Copy link

Coverage Status

coverage: 91.39% (+0.008%) from 91.382%
when pulling a1f0b4f on no_xnt_simulation_config
into 167fe21 on master.

@dachengx dachengx marked this pull request as ready for review April 21, 2024 14:32
@dachengx dachengx merged commit 37e043a into master Apr 21, 2024
8 checks passed
@dachengx dachengx deleted the no_xnt_simulation_config branch April 21, 2024 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants