Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parse USERDISK base on hostname in RunDB #1384

Merged
merged 4 commits into from
May 28, 2024
Merged

Parse USERDISK base on hostname in RunDB #1384

merged 4 commits into from
May 28, 2024

Conversation

dachengx
Copy link
Collaborator

Before you submit this PR: make sure to put all operations-related information in a wiki-note, a PR should be about code and is publicly accessible

What does the code in this PR do / what does it improve?

If hostname contains dali, use UC_DALI_USERDISK.
If hostname contains midway, use UC_MIDWAY_USERDISK.

This can remove the confusion when users see rucio data on /dali but run jobs on node without connection to /dali.

Can you briefly describe how it works?

Can you give a minimal working example (or illustrate with a figure)?

Please include the following if applicable:

  • Update the docstring(s)
  • Update the documentation
  • Tests to check the (new) code is working as desired.
  • Does it solve one of the open issues on github?

Notes on testing

  • Until the automated tests pass, please mark the PR as a draft.
  • On the XENONnT fork we test with database access, on private forks there is no database access for security considerations.

All italic comments can be removed from this template.

@dachengx dachengx requested review from FaroutYLq and cfuselli May 28, 2024 03:49
@dachengx dachengx marked this pull request as ready for review May 28, 2024 03:49
@dachengx dachengx requested review from FaroutYLq and removed request for FaroutYLq and cfuselli May 28, 2024 13:15
@coveralls
Copy link

Coverage Status

coverage: 91.22% (+0.03%) from 91.194%
when pulling 8d07e0d on parse_userdisk
into 1312d95 on master.

@dachengx dachengx requested a review from napoliion May 28, 2024 15:54
Copy link
Contributor

@napoliion napoliion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on fried.rice.edu machine in container 2023.07.1, confirming that straxen.contexts.select_runs() works.

@dachengx dachengx merged commit 34b567b into master May 28, 2024
8 checks passed
@dachengx dachengx deleted the parse_userdisk branch May 28, 2024 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants