Dynamic led window

[tflehmke]

What does the code in this PR do / what does it improve?

This PR implements a dnyamic window for the LED pulse integration in the afterpulse_processing and led_calibration plugins.

Can you briefly describe how it works?

It uses the straxen hit finder to find the first hit inside a fixed, wider window in the record. In the afterpulse plugin, all hits around this hit inside the LED_window_width are then integrated to give the full LED hit. In led calibration plugin, the samples around the first hit given by led_hit_extension are integrated and the maximum is taken from this area.

Please include the following if applicable:

• Update the docstring(s)
• Tests to check the (new) code is working as desired.

[coveralls]

coverage: 90.865% (-0.3%) from 91.138%
when pulling 0e2cd92 on dynamic_led_window
into 1dd8e3e on master.

[yuema137]

Hi @tflehmke Many thanks to this very low-level PR! I went through the two updated files and think they are mostly good. The only possible functional problem that I found is that:

• In led_calibration.py, hits are calculated by the find_hits function in strax, which are not sorted yet (in the afterpulse plugin they are sorted). If we want to only keep the first hit by time, we need to add the sorting here.

I also have some other minor suggestions for naming/comments/changing hard-coded numbers to URLConfigs, please see the single comments for details.

For the speed and memory I'm not really worried, as the calculation of dynamic windows is still O(N), and the size of the dynamic window is much smaller than the hits themselves. But it will still be great if you could provide me an example dataset so that I can test the performance.

[GiovanniVolta]

I would suggest to go to 1.0.0

[GiovanniVolta]

What is the lowest hit detectable? 15 ADC? Can this bias the result?

[tflehmke]

I didn't know how to test the plugin in place in straxen earlier, so I copied the function and run it outside. However doing that I did not have access to the URL config resources. I tested it again in place and it turns out with the hard cutoff of 15 ADC I see a hard cut in the amplitude spectra at 15 ADC. I removed the hard cutoff and always use the hit_min_height_over_noise which removes the hard cut in the spectra.

[yuema137]

It looks all good to me now. Thank you @tflehmke !

[dachengx]

These arguments should be in principle in the snake case. But it is fine to keep things unchanged here to be compatible with the name of configs.