Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small restrax fix - DAQ #1402

Merged
merged 14 commits into from
Aug 25, 2024
Merged

Small restrax fix - DAQ #1402

merged 14 commits into from
Aug 25, 2024

Conversation

cfuselli
Copy link
Member

[DAQ only] restrax did not fail a run in case of problems with the data docs themselves, getting into an infinite loop of try - fail.

restrax did not fail a run in case of problems with the data docs themselves, getting into an infinite loop of try - fail.
@cfuselli cfuselli requested review from mflierm and stevensa22 July 30, 2024 12:35
@coveralls
Copy link

coveralls commented Jul 30, 2024

Coverage Status

coverage: 91.156% (+0.02%) from 91.135%
when pulling c39f3e2 on restrax-fail-fix
into 3e48a58 on master.

bin/restrax Show resolved Hide resolved
Copy link

@stevensa22 stevensa22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me at a glance! Let us see if this then fixes the issues we have been seeing.

@dachengx dachengx merged commit 731d598 into master Aug 25, 2024
8 checks passed
@dachengx dachengx deleted the restrax-fail-fix branch August 25, 2024 09:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants