New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update definition of the SE Score (previously the SE density) for SR1 WIMP #1430

Merged

dachengx merged 16 commits into sr1_leftovers from hsv_update_to_leftovers

Sep 25, 2024

Contributor

chnlkx commented Sep 18, 2024 •

edited

Loading

Before you submit this PR: make sure to put all operations-related information in a wiki-note, a PR should be about code and is publicly accessible

What does the code in this PR do / what does it improve?

Update the se_score calculated for the hotspot veto cut to use a score based on the distance and position reconstruction resolution.

This PR will provide input for the hotspot veto cut in https://github.com/XENONnT/cutax/pull/479

Can you briefly describe how it works?

Can you give a minimal working example (or illustrate with a figure)?

Please include the following if applicable:

Update the docstring(s)
Update the documentation
Tests to check the (new) code is working as desired.
Does it solve one of the open issues on github?

Notes on testing

Until the automated tests pass, please mark the PR as a draft.
On the XENONnT fork we test with database access, on private forks there is no database access for security considerations.

All italic comments can be removed from this template.

chnlkx and others added 4 commits

September 18, 2024 01:06


          Update score definition. Modify file names.

88f1744


          [pre-commit.ci] auto fixes from pre-commit.com hooks

03228bb

for more information, see https://pre-commit.ci


          Modify file names in the initialization file.

01e63c7


          Merge branch 'hsv_update_to_leftovers' of github.com:XENONnT/straxen …

474e4b8

…into hsv_update_to_leftovers

chnlkx marked this pull request as draft

September 18, 2024 07:05

chnlkx and others added 2 commits

September 19, 2024 22:29


          Rearrangenames. Move sr phase assignment elsewhere.

88bf707


          [pre-commit.ci] auto fixes from pre-commit.com hooks

a112f16

for more information, see https://pre-commit.ci

chnlkx changed the title ~~Update definition of the SE Nearby Score (previously the SE density) for SR1 WIMP~~ Update definition of the SE Score (previously the SE density) for SR1 WIMP

dachengx requested changes

View reviewed changes

straxen/plugins/events/event_se_score.py Show resolved Hide resolved

straxen/plugins/peaks/peak_se_score.py Outdated Show resolved Hide resolved

straxen/plugins/peaks/peak_se_score.py Outdated

+                      return 2 * (self.se_time_search_window_left + self.se_time_search_window_right)
+                  def setup(self):
+                      self._para_a = 1

Collaborator

dachengx Sep 22, 2024

You should better set self._para_a = self.para_a and, make para_a a straxen.URLConfig.

Contributor Author

chnlkx Sep 23, 2024 •

edited

Loading

To avoid having same name with the para_a in cutax, I added para_a_place_holder here

straxen/plugins/peaks/peak_se_score.py Outdated Show resolved Hide resolved

straxen/plugins/peaks/peak_se_score.py Outdated Show resolved Hide resolved

straxen/plugins/peaks/peak_se_score.py Outdated Show resolved Hide resolved

chnlkx added 2 commits

September 22, 2024 22:14


          Add url configs and modify code style.

36d89ff


          Merge branch 'hsv_update_to_leftovers' of github.com:XENONnT/straxen …

beb9759

…into hsv_update_to_leftovers

chnlkx requested a review from dachengx

September 23, 2024 03:16

Collaborator

dachengx commented Sep 23, 2024

@chnlkx please add the dependency of PRs in straxen and cutax in the description.

dachengx requested changes

View reviewed changes

straxen/plugins/peaks/peak_se_score.py Outdated Show resolved Hide resolved

dachengx and others added 4 commits

September 23, 2024 09:58


          Merge branch 'sr1_leftovers' into hsv_update_to_leftovers

f61ad7d


          Modify the parameter names.

00e184e


          Merge branch 'hsv_update_to_leftovers' of github.com:XENONnT/straxen …

e42b4b4

…into hsv_update_to_leftovers


          Fix data type in url config.

2be22f6

dachengx reviewed

View reviewed changes

straxen/plugins/peaks/peak_se_score.py Outdated Show resolved Hide resolved


          Add docstring for the eps used to prevent divide by zero.

f39e89e

dachengx reviewed

View reviewed changes

straxen/plugins/peaks/peak_se_score.py Show resolved Hide resolved

straxen/plugins/peaks/peak_se_score.py Outdated Show resolved Hide resolved


          Reformmated with precommit.

1efe2cf

GiovanniVolta self-requested a review

September 24, 2024 13:15

GiovanniVolta requested changes

View reviewed changes

straxen/plugins/peaks/peak_se_score.py Show resolved Hide resolved

straxen/plugins/peaks/peak_se_score.py Outdated Show resolved Hide resolved

straxen/plugins/peaks/peak_se_score.py Outdated Show resolved Hide resolved

dachengx reviewed

View reviewed changes

straxen/plugins/peaks/peak_se_score.py Outdated Show resolved Hide resolved

chnlkx marked this pull request as ready for review

September 24, 2024 13:49

chnlkx added 2 commits

September 25, 2024 06:45


          Add docstrings. Remove redundant code.

1376a46


          Add docstring for the 2D Gaussian.

02a119e

chnlkx requested review from dachengx and GiovanniVolta

September 25, 2024 12:10

dachengx approved these changes

View reviewed changes

Collaborator

dachengx left a comment

Thanks a lot! @chnlkx

GiovanniVolta approved these changes

View reviewed changes

dachengx merged commit b665bc6 into sr1_leftovers

7 checks passed

dachengx deleted the hsv_update_to_leftovers branch

September 25, 2024 14:41

dachengx added a commit to XENONnT/axidence that referenced this pull request


          Use SE scores instead of SE density

Following XENONnT/straxen#1430 and XENONnT/cutax#479

dachengx mentioned this pull request

Use SE scores instead of SE density XENONnT/axidence#87

Merged

dachengx added a commit to XENONnT/axidence that referenced this pull request


          Use SE scores instead of SE density (#87)

a0b187a

* Use SE scores instead of SE density

Following XENONnT/straxen#1430 and XENONnT/cutax#479

* Use `sr1_leftovers` for the installation, later will change to a tagged version

dachengx added a commit that referenced this pull request


          Merge branch 'sr1_leftovers' into master (#1478)

ded7eab

* Update pytest.yml (#1431)

* Update pytest.yml

Specify the strax to be v1.6.5

* add install base_env

* Add force reinstall

* Update definition of the SE Score (previously the SE density) for SR1 WIMP (#1430)

* Update score definition. Modify file names.

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* Modify file names in the initialization file.

* Rearrangenames. Move sr phase assignment elsewhere.

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* Add url configs and modify code style.

* Modify the parameter names.

* Fix data type in url config.

* Add docstring for the eps used to prevent divide by zero.

* Reformmated with precommit.

* Add docstrings. Remove redundant code.

* Add docstring for the 2D Gaussian.

---------

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Dacheng Xu <dx2227@columbia.edu>

* Copy #1417 (#1438)

* Bump to v2.2.6 (#1441)

* Bump version: 2.2.4 → 2.2.6

* Update HISTORY.md

* Constraint strax version

---------

Co-authored-by: Kexin Liu <lkx21@mails.tsinghua.edu.cn>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet