Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specify available RSE in RucioRemoteBackend #1435

Merged
merged 1 commit into from
Oct 4, 2024

Conversation

dachengx
Copy link
Collaborator

@dachengx dachengx commented Oct 4, 2024

Before you submit this PR: make sure to put all operations-related information in a wiki-note, a PR should be about code and is publicly accessible

What does the code in this PR do / what does it improve?

Related: XENONnT/outsource#93

In this PR, the rses_only restricted that the data_type can only be downloaded from the RSE in it.

Can you briefly describe how it works?

Can you give a minimal working example (or illustrate with a figure)?

Please include the following if applicable:

  • Update the docstring(s)
  • Update the documentation
  • Tests to check the (new) code is working as desired.
  • Does it solve one of the open issues on github?

Notes on testing

  • Until the automated tests pass, please mark the PR as a draft.
  • On the XENONnT fork we test with database access, on private forks there is no database access for security considerations.

All italic comments can be removed from this template.

@dachengx dachengx marked this pull request as ready for review October 4, 2024 19:22
@coveralls
Copy link

coveralls commented Oct 4, 2024

Coverage Status

coverage: 90.379% (+0.02%) from 90.36%
when pulling 1874c62 on rucio_remote_backend_rses_only
into a412b43 on master.

@dachengx dachengx requested a review from yuema137 October 4, 2024 19:59
@dachengx dachengx merged commit 35917e7 into master Oct 4, 2024
8 checks passed
@dachengx dachengx deleted the rucio_remote_backend_rses_only branch October 4, 2024 20:37
Copy link
Collaborator

@yuema137 yuema137 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR adds an input to select available rses. Looks good to me

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants