Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add level in the tree when drawing dependency tree #1446

Merged
merged 2 commits into from
Oct 13, 2024
Merged

Conversation

dachengx
Copy link
Collaborator

@dachengx dachengx commented Oct 11, 2024

Before you submit this PR: make sure to put all operations-related information in a wiki-note, a PR should be about code and is publicly accessible

This is a follow-up PR of AxFoundation/strax#896

What does the code in this PR do / what does it improve?

It will print the level and order of a data_type in a tree if include_level=True.

Can you briefly describe how it works?

Can you give a minimal working example (or illustrate with a figure)?

Please include the following if applicable:

  • Update the docstring(s)
  • Update the documentation
  • Tests to check the (new) code is working as desired.
  • Does it solve one of the open issues on github?

Notes on testing

  • Until the automated tests pass, please mark the PR as a draft.
  • On the XENONnT fork we test with database access, on private forks there is no database access for security considerations.

All italic comments can be removed from this template.

@coveralls
Copy link

coveralls commented Oct 11, 2024

Coverage Status

coverage: 89.768% (-0.004%) from 89.772%
when pulling 3553607 on add_level_to_tree
into 9d2a6b6 on master.

@dachengx dachengx marked this pull request as ready for review October 12, 2024 22:08
@dachengx dachengx merged commit f514d5e into master Oct 13, 2024
7 of 8 checks passed
@dachengx dachengx deleted the add_level_to_tree branch October 13, 2024 20:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants