Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust saving preference #1451

Merged
merged 6 commits into from
Oct 16, 2024
Merged

Adjust saving preference #1451

merged 6 commits into from
Oct 16, 2024

Conversation

yuema137
Copy link
Collaborator

The general logic of the saving strategy could be summarized as:

  1. The plugins that involve heavy computation should be saved at least once (there could be duplications in subsequent plugins)
  2. The plugins that could be easily calculated from parents should not be saved

The veto_regions and event_pattern_fit fall into the first categories. As they are not computed again for other child plugins, we should always save them during their own computations.

@coveralls
Copy link

coveralls commented Oct 16, 2024

Coverage Status

Changes unknown
when pulling 89fd16d on adjust_saving_preference
into ** on master**.

@dachengx dachengx merged commit c2c0400 into master Oct 16, 2024
6 of 7 checks passed
@dachengx dachengx deleted the adjust_saving_preference branch October 16, 2024 17:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants