Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove pymongo_collection because it is deprecated #137

Merged
merged 1 commit into from
Oct 7, 2024
Merged

Remove pymongo_collection because it is deprecated #137

merged 1 commit into from
Oct 7, 2024

Conversation

dachengx
Copy link
Contributor

@dachengx dachengx commented Oct 4, 2024

If we are sure that nowhere in nT we are still using utilix.rundb.pymongo_collection.

@dachengx dachengx requested a review from yuema137 October 4, 2024 21:40
@dachengx dachengx marked this pull request as ready for review October 4, 2024 21:40
@dachengx dachengx merged commit 66fbbd0 into master Oct 7, 2024
2 checks passed
@dachengx dachengx deleted the rm_pymongo_collection branch October 7, 2024 02:38
@yuema137
Copy link
Contributor

yuema137 commented Oct 7, 2024 •
edited
Loading

The renaming looks reasonable to me together with https://github.com/XENONnT/straxen/pull/1437
I have checked that in outsource we only import and use xent_collection

@yuema137 yuema137 mentioned this pull request Oct 7, 2024
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yuema137 yuema137 Awaiting requested review from yuema137

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dachengx @yuema137