-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove redundant mongo #138
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
APIUploader
and APIDownloader
are still used: https://github.com/XENONnT/private_nt_aux_files/blob/4b155401e986b3c33a37b687c27d12c757763c27/ntauxfiles/uploader.py#L12
@dachengx Please see the |
You need to solve the conflicts with the master branch. |
Actually, haha, I suggest keeping these things to utilix but not straxen, because straxen is too heavy, and |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @yuema137 Please later move RunDB related classes from straxen to utilix.
@dachengx Yes let's first gather the functions into one file in straxen, then move it to utilix. Then there's no need to modify |
Fix #136
The classes are redefined in
straxen
: straxen/storange/mongo_storage.py and all of the other xenon packages are only using the implementation instraxen
(See #136 ). Given the independence of this module, it doesn't really matter if it's implemented instraxen
orutilix
. To avoid potential ambiguity in the future, a good practice is to remove the implementation here.I have checked that the
mongo_files
module is independent of other modules inutilix
, and it's safe to remove it.