Fix command execution for Windows -- npm-run instead of npx #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tly escape arguments with quotes or spaces (and seems unmaintained, so no chance of a fix, making it unsuited for our usages). See npm/npx#10 and npm/npx#43
… node, it will then find any node_modules binaries on its own (see previous commit)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use npm-run instead of npx to run dev_cmds because npx doesn't correctly escape arguments with quotes or spaces on Windows (and seems unmaintained, so no chance of a fix, making it unsuited for our usages).
See npm/npx#10 and npm/npx#43
Since
devcmdnow takes care of PATH augmentation,devcmd-clican just executenoderegularly and doesn't need to go through npx (this was probably already redundant before).