Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

XLS-33d: Compact Fungible Tokens (CFTs) #109

Merged
merged 7 commits into from
Jun 22, 2023
Merged

Conversation

ledhed2222
Copy link
Collaborator

@ledhed2222 ledhed2222 commented May 15, 2023

Update: This PR has been merged and the XLS-33d spec can be viewed here.

Please feel free to open a new PR to propose any changes or updates to the spec.


Initial commit of XLS-33d spec

Per CONTRIBUTING.md - this is ready to merge as a draft spec. The spec will continue to be updated with new PRs after this!

XLS-33d/README.md Outdated Show resolved Hide resolved
XLS-33d/README.md Outdated Show resolved Hide resolved
XLS-33d/README.md Outdated Show resolved Hide resolved
XLS-33d/README.md Outdated Show resolved Hide resolved
XLS-33d/README.md Outdated Show resolved Hide resolved
@ledhed2222 ledhed2222 marked this pull request as ready for review May 19, 2023 20:37
@sappenin sappenin self-requested a review May 19, 2023 20:49
Copy link
Collaborator

@sappenin sappenin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM as a DRAFT.

XLS-0033d-CFTs/README.md Outdated Show resolved Hide resolved
XLS-0033d-CFTs/README.md Outdated Show resolved Hide resolved
XLS-0033d-CFTs/README.md Outdated Show resolved Hide resolved
XLS-0033d-CFTs/README.md Outdated Show resolved Hide resolved
XLS-0033d-CFTs/README.md Outdated Show resolved Hide resolved
XLS-0033d-CFTs/README.md Outdated Show resolved Hide resolved
XLS-0033d-CFTs/README.md Outdated Show resolved Hide resolved
XLS-0033d-CFTs/README.md Outdated Show resolved Hide resolved
XLS-0033d-CFTs/README.md Outdated Show resolved Hide resolved
XLS-0033d-CFTs/README.md Outdated Show resolved Hide resolved
@sappenin
Copy link
Collaborator

+1 to all of the changes proposed by @intelliot (I can't merge them though).

:)

XLS-0033d-CFTs/README.md Outdated Show resolved Hide resolved
XLS-0033d-CFTs/README.md Outdated Show resolved Hide resolved
Copy link
Contributor

@Silkjaer Silkjaer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few fixes needed before it can be merged :)

XLS-0033d-CFTs/README.md Outdated Show resolved Hide resolved
XLS-0033d-CFTs/README.md Show resolved Hide resolved
XLS-0033d-CFTs/README.md Show resolved Hide resolved
@intelliot intelliot changed the title XLS-33 draft XLS-33d: Compact Fungible Tokens (CFTs) May 31, 2023
@intelliot intelliot removed their assignment Jun 6, 2023
@intelliot
Copy link
Collaborator

@ledhed2222 please respond to the above comments, at your convenience

@ledhed2222
Copy link
Collaborator Author

@intelliot done :)

@sappenin
Copy link
Collaborator

@Silkjaer - all requested changes have been merged by @ledhed2222. Once you give a final approval I'll go ahead and merge this one.

@intelliot intelliot mentioned this pull request Jun 20, 2023
@ledhed2222
Copy link
Collaborator Author

@Silkjaer hey there! can you review again please?

Copy link
Contributor

@Silkjaer Silkjaer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@intelliot intelliot merged commit ce29208 into XRPLF:master Jun 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants