Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

XLS-38d: Cross-Chain Bridges #118

Merged
merged 3 commits into from
Jul 11, 2023
Merged

XLS-38d: Cross-Chain Bridges #118

merged 3 commits into from
Jul 11, 2023

Conversation

mvadari
Copy link
Collaborator

@mvadari mvadari commented Jul 7, 2023 •
edited by intelliot
Loading

Initial commit of XLS-38d spec

Per CONTRIBUTING.md - this is ready to merge as a draft spec. The spec can continue to be updated with new PRs after this.

Prior discussions of this spec can be found here: #92

Silkjaer
Silkjaer requested changes Jul 7, 2023
View reviewed changes
Copy link
Contributor

@Silkjaer Silkjaer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add author affiliation and add the name of the XLS to the folder

@mvadari mvadari requested a review from Silkjaer July 7, 2023 18:23
Silkjaer
Silkjaer approved these changes Jul 7, 2023
View reviewed changes
Copy link
Contributor

@Silkjaer Silkjaer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I think if it has been decided to go in one direction with the design, maybe the appendixes with alternate options should be removed? For now I think it's fine to keep them, but eventually when moving to spec at least :)

@Silkjaer Silkjaer merged commit 1a15c60 into XRPLF:master Jul 11, 2023
@intelliot
Copy link
Collaborator

For future readers: see the current version of XLS-38d here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Silkjaer Silkjaer Silkjaer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mvadari @intelliot @Silkjaer