Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

XLS-30: AMM Specification #125

Merged
merged 19 commits into from
Oct 4, 2023
Merged

XLS-30: AMM Specification #125

merged 19 commits into from
Oct 4, 2023

Conversation

aanchal4
Copy link
Contributor

@aanchal4 aanchal4 commented Aug 9, 2023

Prior discussion about this spec can be found here: #78

XLS-30/README.md Outdated Show resolved Hide resolved
XLS-30/README.md Outdated Show resolved Hide resolved
XLS-30/README.md Outdated Show resolved Hide resolved
XLS-30/README.md Show resolved Hide resolved
XLS-30/README.md Outdated Show resolved Hide resolved
@intelliot
Copy link
Collaborator

@aanchal4 - can you update this PR for the latest changes in AMM? For example, removing lsfAMM

aanchal4 and others added 4 commits August 29, 2023 19:49
Co-authored-by: Elliot Lee <github.public@intelliot.com>
Co-authored-by: Elliot Lee <github.public@intelliot.com>
Co-authored-by: Elliot Lee <github.public@intelliot.com>
Co-authored-by: Elliot Lee <github.public@intelliot.com>
XLS-30/README.md Outdated Show resolved Hide resolved
XLS-30/README.md Outdated Show resolved Hide resolved
XLS-30/README.md Show resolved Hide resolved
XLS-30/README.md Outdated Show resolved Hide resolved
XLS-30/README.md Outdated Show resolved Hide resolved
XLS-30/README.md Show resolved Hide resolved
XLS-30/README.md Show resolved Hide resolved
XLS-30/README.md Show resolved Hide resolved
XLS-30/README.md Show resolved Hide resolved
XLS-30/README.md Show resolved Hide resolved
Copy link
Collaborator

@gregtatcam gregtatcam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I left two minor comments.

XLS-30/README.md Outdated Show resolved Hide resolved
XLS-30/README.md Outdated Show resolved Hide resolved
Copy link
Collaborator

@gregtatcam gregtatcam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 LGTM

XLS-30/README.md Outdated Show resolved Hide resolved
XLS-30/README.md Outdated Show resolved Hide resolved
XLS-30/README.md Outdated Show resolved Hide resolved
aanchal4 and others added 4 commits September 28, 2023 13:37
Co-authored-by: Elliot Lee <github.public@intelliot.com>
Co-authored-by: Elliot Lee <github.public@intelliot.com>
Co-authored-by: Elliot Lee <github.public@intelliot.com>
@intelliot intelliot requested review from Silkjaer and sappenin October 2, 2023 15:45
intelliot added a commit to aanchal4/XRPL-Standards that referenced this pull request Oct 2, 2023
XLS-30 can be found here: XRPLF#125
@intelliot intelliot merged commit 2a9010b into XRPLF:master Oct 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants