Skip to content

Commit

Permalink
Another fix of clang-tidy workflow (#1026)
Browse files Browse the repository at this point in the history
Another fix for clang-tidy nightly check for #884
  • Loading branch information
kuznetsss authored Dec 11, 2023
1 parent acf359d commit 7d1d174
Show file tree
Hide file tree
Showing 2 changed files with 52 additions and 58 deletions.
55 changes: 0 additions & 55 deletions .github/actions/clang_tidy/action.yml

This file was deleted.

55 changes: 52 additions & 3 deletions .github/workflows/clang-tidy.yml
Original file line number Diff line number Diff line change
Expand Up @@ -7,8 +7,7 @@ on:
branches: [develop]
paths:
- .clang_tidy
- '.github/**clang_tidy**'
- '.github/**clang-tidy**'
- .github/workflows/clang-tidy.yml

jobs:
clang_tidy:
Expand Down Expand Up @@ -49,5 +48,55 @@ jobs:
conan_cache_hit: ${{ steps.restore_cache.outputs.conan_cache_hit }}
build_type: Release

- name: Get number of threads
uses: ./.github/actions/get_number_of_threads
id: number_of_threads

- name: Run clang-tidy
uses: ./.github/actions/clang_tidy
continue-on-error: true
shell: bash
id: run_clang_tidy
run: |
run-clang-tidy-17 -p build -j ${{ steps.number_of_threads.outputs.threads_number }} -fix -quiet 1>output.txt
- name: Print issues found
if: ${{ steps.run_clang_tidy.outcome != 'success' }}
shell: bash
run: |
sed -i '/error\||/!d' ./output.txt
cat output.txt
rm output.txt
- name: Create an issue
if: ${{ steps.run_clang_tidy.outcome != 'success' }}
id: create_issue
shell: bash
env:
GH_TOKEN: ${{ github.token }}
run: |
echo -e 'Clang-tidy found issues in the code:\n' > issue.md
echo -e "List of the issues found: ${{ github.server_url }}/${{ github.repository }}/actions/runs/${{ github.run_id }}/" >> issue.md
gh issue create --assignee 'cindyyan317,godexsoft,kuznetsss' --label bug --title 'Clang-tidy found bugs in code🐛' --body-file ./issue.md > create_issue.log
created_issue=$(cat create_issue.log | sed 's|.*/||')
echo "created_issue=$created_issue" >> $GITHUB_OUTPUT
rm create_issue.log issue.md
- name: Create PR with fixes
if: ${{ steps.run_clang_tidy.outcome != 'success' }}
uses: peter-evans/create-pull-request@v5
env:
GH_REPO: ${{ github.repository }}
GH_TOKEN: ${{ github.token }}
with:
commit-message: '[CI] clang-tidy auto fixes'
branch: 'clang_tidy/autofix'
branch-suffix: timestamp
delete-branch: true
title: '[CI] clang-tidy auto fixes'
body: 'Fixes #${{ steps.create_issue.outputs.created_issue }}. Please review and commit clang-tidy fixes'
reviewers: 'cindyyan317,godexsoft,kuznetsss'

- name: Fail the job
if: ${{ steps.run_clang_tidy.outcome != 'success' }}
shell: bash
run: exit 1

0 comments on commit 7d1d174

Please sign in to comment.