Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix logging of SubscriptionSource #1616

Closed
kuznetsss opened this issue Aug 28, 2024 · 1 comment · Fixed by #1632
Closed

Fix logging of SubscriptionSource #1616

kuznetsss opened this issue Aug 28, 2024 · 1 comment · Fixed by #1632
Assignees
@kuznetsss
Labels
bug Something isn't working

Comments

@kuznetsss
Copy link
Collaborator

Issue Description

SubscriptionSource's logger now has channel GrpcSource. Also there could be added a better logging for SubscriptionSource and switching of currently forwarding source.
@kuznetsss kuznetsss added the bug Something isn't working label Aug 28, 2024
@kuznetsss kuznetsss self-assigned this Aug 29, 2024
@kuznetsss kuznetsss mentioned this issue Aug 29, 2024
Merged
kuznetsss added a commit that referenced this issue Aug 29, 2024
@kuznetsss
fix: Fix logging in SubscriptionSource (#1617)
5004dc4 
For #1616. Later should be ported to develop as well.
@kuznetsss
Copy link
Collaborator Author

Fixed for the upcoming 2.2.3 release but still should be fixed in develop branch.

kuznetsss added a commit to kuznetsss/clio that referenced this issue Sep 6, 2024
@kuznetsss
fix: Fix logging in SubscriptionSource (XRPLF#1617)
f9f66d3 
For XRPLF#1616. Later should be ported to develop as well.
@kuznetsss kuznetsss mentioned this issue Sep 6, 2024
Merged
kuznetsss added a commit that referenced this issue Sep 25, 2024
@kuznetsss
fix: Fix logging in SubscriptionSource (#1617) (#1632)
b08447e 
Fixes #1616. 
Cherry pick of #1617 into develop.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kuznetsss kuznetsss

Labels
bug Something isn't working
Projects
Clio
Status: ✅ Merged
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: Fix logging in SubscriptionSource (#1617) kuznetsss/clio
1 participant
@kuznetsss