Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix forwarded flag placement #1101

Merged

Conversation

godexsoft
Copy link
Collaborator

Fixes #1091

Please note that we still add extra fields status and type that according to the response format document should not be there. However, this have always been Clio's behaviour and as we don't consider extra flags breaking the API we can leave them. May want to deprecate them eventually though.

@godexsoft godexsoft requested a review from cindyyan317 January 12, 2024 13:06
Copy link

codecov bot commented Jan 12, 2024

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (ac97788) 54.75% compared to head (d35b34d) 54.77%.

Files Patch % Lines
src/web/RPCServerHandler.h 75.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1101      +/-   ##
===========================================
+ Coverage    54.75%   54.77%   +0.01%     
===========================================
  Files          206      206              
  Lines        10475    10479       +4     
  Branches      5582     5585       +3     
===========================================
+ Hits          5736     5740       +4     
  Misses        3415     3415              
  Partials      1324     1324              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@godexsoft godexsoft merged commit ce86572 into XRPLF:develop Jan 12, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

forwarded is in the result of response for error cases and out of result for others.
2 participants