Enable DB tests via ScyllaDB service #1103
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #1103 +/- ##
===========================================
+ Coverage 54.75% 59.66% +4.90%
===========================================
Files 206 206
Lines 10479 10479
Branches 5585 5585
===========================================
+ Hits 5738 6252 +514
+ Misses 3416 2639 -777
- Partials 1325 1588 +263 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds backend tests to CI. Currently only for the one place where we upload code coverage stats.
This could be extended to Nightly builds with similar changes but i'm not sure if we need it there.
The way we pass the hostname for ScyllaDB is by using a custom arg to
clio_testscalled--backend_host. This gets parsed intoTestGlobalsand is later propagated to all places where we need this host. The host itself is set toscylladbbecause the database is running as aservice(see the doc) and so we can leverage bridge networks instead of port forwarding.