Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automatically detect missing doxygen comments #1226

Merged
merged 18 commits into from
Mar 5, 2024

Conversation

godexsoft
Copy link
Collaborator

Fixes #1216

Copy link

codecov bot commented Mar 2, 2024

Codecov Report

Attention: Patch coverage is 33.33333% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 66.57%. Comparing base (51150d8) to head (d8ff16f).
Report is 1 commits behind head on develop.

Files Patch % Lines
src/rpc/common/impl/HandlerProvider.cpp 0.00% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #1226   +/-   ##
========================================
  Coverage    66.57%   66.57%           
========================================
  Files          241      241           
  Lines        11012    11012           
  Branches      5623     5623           
========================================
  Hits          7331     7331           
  Misses        1939     1939           
  Partials      1742     1742           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@kuznetsss kuznetsss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, that's a really good automation. A few thoughts what could be improved.

.githooks/check-docs Outdated Show resolved Hide resolved
.githooks/check-docs Outdated Show resolved Hide resolved
.githooks/check-docs Show resolved Hide resolved
.githooks/pre-commit Show resolved Hide resolved
@kuznetsss
Copy link
Collaborator

Please update the documentation about pre-commit hook.

@godexsoft
Copy link
Collaborator Author

@cindyyan317 @kuznetsss it looks like there is some caching issue or something with clang-tidy. I suggest we merge it as is (after review and fixes if needed) and tomorrow we will find out if clang-tidy will be happy or not.

Copy link
Collaborator

@cindyyan317 cindyyan317 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's go 💯

@godexsoft godexsoft merged commit 73d427c into XRPLF:develop Mar 5, 2024
12 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Check doxygen completnes on CI (Version: 2.1.0)
3 participants