-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Automatically detect missing doxygen comments #1226
Automatically detect missing doxygen comments #1226
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #1226 +/- ##
========================================
Coverage 66.57% 66.57%
========================================
Files 241 241
Lines 11012 11012
Branches 5623 5623
========================================
Hits 7331 7331
Misses 1939 1939
Partials 1742 1742 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, that's a really good automation. A few thoughts what could be improved.
Please update the documentation about pre-commit hook. |
@cindyyan317 @kuznetsss it looks like there is some caching issue or something with clang-tidy. I suggest we merge it as is (after review and fixes if needed) and tomorrow we will find out if clang-tidy will be happy or not. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's go 💯
Fixes #1216