Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Published subscription message counters #1618

Merged

Conversation

godexsoft
Copy link
Collaborator

This PR adds counters to track the amount of published messages for each subscription stream.

Copy link

codecov bot commented Aug 29, 2024

Codecov Report

Attention: Patch coverage is 71.42857% with 4 lines in your changes missing coverage. Please review.

Project coverage is 67.80%. Comparing base (5004dc4) to head (48beaed).
Report is 1 commits behind head on release/2.2.3.

Files with missing lines Patch % Lines
src/feed/impl/Util.hpp 60.00% 0 Missing and 2 partials ⚠️
src/feed/impl/ProposedTransactionFeed.hpp 0.00% 0 Missing and 1 partial ⚠️
src/feed/impl/TransactionFeed.hpp 0.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@              Coverage Diff               @@
##           release/2.2.3    #1618   +/-   ##
==============================================
  Coverage          67.80%   67.80%           
==============================================
  Files                234      234           
  Lines               9438     9451   +13     
  Branches            5264     5271    +7     
==============================================
+ Hits                6399     6408    +9     
  Misses              1653     1653           
- Partials            1386     1390    +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@godexsoft godexsoft marked this pull request as ready for review August 29, 2024 15:45
@godexsoft godexsoft changed the title Published subscription message counters feat: Published subscription message counters Aug 29, 2024
@godexsoft godexsoft merged commit 2e2740d into XRPLF:release/2.2.3 Aug 29, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants