Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Subscription source bugs fix #1626

Merged
merged 7 commits into from
Sep 5, 2024

Remove atomic

fbb55d6
Select commit
Loading
Failed to load commit list.
Merged

fix: Subscription source bugs fix #1626

Remove atomic
fbb55d6
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Sep 5, 2024 in 1s

67.83% (target 50.00%)

View this Pull Request on Codecov

67.83% (target 50.00%)

Details

Codecov Report

Attention: Patch coverage is 86.20690% with 4 lines in your changes missing coverage. Please review.

Project coverage is 67.83%. Comparing base (2e2740d) to head (fbb55d6).

Files with missing lines Patch % Lines
src/etl/impl/SubscriptionSource.cpp 87.50% 0 Missing and 2 partials ⚠️
src/etl/LoadBalancer.cpp 88.88% 1 Missing ⚠️
src/util/requests/impl/WsConnectionImpl.hpp 75.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files 
@@                Coverage Diff                @@
##           release/2.2.3    #1626      +/-   ##
=================================================
+ Coverage          67.80%   67.83%   +0.03%     
=================================================
  Files                234      234              
  Lines               9451     9463      +12     
  Branches            5271     5277       +6     
=================================================
+ Hits                6408     6419      +11     
- Misses              1653     1654       +1     
  Partials            1390     1390

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

View more details on Codecov