Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Subscription source bugs fix (#1626) #1633

Merged
merged 1 commit into from
Sep 6, 2024

fix: Subscription source bugs fix (#1626)

352b8bc
Select commit
Loading
Failed to load commit list.
Merged

fix: Subscription source bugs fix (#1626) #1633

fix: Subscription source bugs fix (#1626)
352b8bc
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Sep 6, 2024 in 1s

69.90% (target 50.00%)

View this Pull Request on Codecov

69.90% (target 50.00%)

Details

Codecov Report

Attention: Patch coverage is 86.20690% with 4 lines in your changes missing coverage. Please review.

Project coverage is 69.90%. Comparing base (1d33b8e) to head (352b8bc).

Files with missing lines Patch % Lines
src/etl/impl/SubscriptionSource.cpp 87.50% 0 Missing and 2 partials ⚠️
src/etl/LoadBalancer.cpp 88.88% 1 Missing ⚠️
src/util/requests/impl/WsConnectionImpl.hpp 75.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files 
@@             Coverage Diff             @@
##           develop    #1633      +/-   ##
===========================================
+ Coverage    69.88%   69.90%   +0.02%     
===========================================
  Files          260      260              
  Lines         9958     9970      +12     
  Branches      5488     5494       +6     
===========================================
+ Hits          6959     6970      +11     
- Misses        1587     1588       +1     
  Partials      1412     1412

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

View more details on Codecov