Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: No ALL_CAPS #1760

Open
wants to merge 26 commits into
base: develop
Choose a base branch
from
Open

Conversation

godexsoft
Copy link
Collaborator

@godexsoft godexsoft commented Nov 26, 2024

This PR renames identifiers according to the updated clang-tidy configuration.
It also fixes the placement of constexpr when used with static and small other cosmetic fixes.

Let me know what you think.
I don't really like how non-const statics became kALL_CAPS formatted but clang-tidy does not seem to be able to make the distinction very well.

Copy link

codecov bot commented Nov 28, 2024

Codecov Report

Attention: Patch coverage is 64.19966% with 208 lines in your changes missing coverage. Please review.

Project coverage is 71.39%. Comparing base (efe5d08) to head (ed29df5).

Files with missing lines Patch % Lines
src/rpc/handlers/LedgerEntry.hpp 62.96% 7 Missing and 13 partials ⚠️
src/util/log/Logger.cpp 27.27% 15 Missing and 1 partial ⚠️
src/app/ClioApplication.cpp 0.00% 11 Missing ⚠️
src/main/Main.cpp 0.00% 8 Missing ⚠️
src/etl/impl/Transformer.hpp 0.00% 7 Missing ⚠️
src/rpc/RPCHelpers.cpp 80.00% 2 Missing and 5 partials ⚠️
src/util/config/Config.cpp 56.25% 2 Missing and 5 partials ⚠️
src/web/impl/HttpBase.hpp 50.00% 1 Missing and 6 partials ⚠️
.../migration/cassandra/CassandraMigrationBackend.hpp 0.00% 6 Missing ⚠️
src/rpc/common/MetaProcessors.hpp 25.00% 0 Missing and 6 partials ⚠️
... and 72 more
Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #1760   +/-   ##
========================================
  Coverage    71.39%   71.39%           
========================================
  Files          314      314           
  Lines        13111    13111           
  Branches      6683     6683           
========================================
  Hits          9360     9360           
  Misses        1967     1967           
  Partials      1784     1784           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@godexsoft godexsoft requested review from cindyyan317, PeterChen13579 and kuznetsss and removed request for cindyyan317 and PeterChen13579 December 2, 2024 20:27
@godexsoft godexsoft marked this pull request as ready for review December 2, 2024 20:30
cindyyan317
cindyyan317 previously approved these changes Dec 3, 2024
Copy link
Collaborator

@cindyyan317 cindyyan317 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think kALL_CAPS is fine. I don't down what k means thou.

I am happy to see make_ gone...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants