-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: No ALL_CAPS #1760
base: develop
Are you sure you want to change the base?
chore: No ALL_CAPS #1760
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #1760 +/- ##
========================================
Coverage 71.39% 71.39%
========================================
Files 314 314
Lines 13111 13111
Branches 6683 6683
========================================
Hits 9360 9360
Misses 1967 1967
Partials 1784 1784 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think kALL_CAPS is fine. I don't down what k means thou.
I am happy to see make_
gone...
This PR renames identifiers according to the updated
clang-tidy
configuration.It also fixes the placement of
constexpr
when used withstatic
and small other cosmetic fixes.Let me know what you think.
I don't really like how non-const statics became
kALL_CAPS
formatted butclang-tidy
does not seem to be able to make the distinction very well.