[FOLD] divide by zero fix

XRPLF · Jun 26, 2020 · 0fbeb2e · 0fbeb2e
1 parent 76096ae
commit 0fbeb2e
Showing 1 changed file with 10 additions and 8 deletions.
diff --git a/src/ripple/app/ledger/impl/LedgerMaster.cpp b/src/ripple/app/ledger/impl/LedgerMaster.cpp
@@ -1088,14 +1088,16 @@ LedgerMaster::checkAccept(std::shared_ptr<Ledger const> const& ledger)
             // We report only if (1) we have accumulated validation messages
             // from 90% validators from the UNL, and (2) 60% of validators
             // running the rippled implementation have higher version numbers.
-            constexpr std::size_t reportingPercent = 90;
-            constexpr std::size_t cutoffPercent = 60;
-            needPrint = calculatePercent(
-                            vals.size(),
-                            app_.validators().getQuorumKeys().second.size()) >=
-                    reportingPercent &&
-                calculatePercent(higherVersionCount, rippledCount) >=
-                    cutoffPercent;
+            if (higherVersionCount > 0)
+            {
+                constexpr std::size_t reportingPercent = 90;
+                constexpr std::size_t cutoffPercent = 60;
+                auto const sz{app_.validators().getQuorumKeys().second.size()};
+                needPrint = sz > 0 &&
+                    calculatePercent(vals.size(), sz) >= reportingPercent &&
+                    calculatePercent(higherVersionCount, rippledCount) >=
+                        cutoffPercent;
+            }
         }
         // To throttle the warning messages, instead of printing a warning
         // every flag ledger, we print every week.