Minor improvements from review

XRPLF · Jun 11, 2024 · 585268c · 585268c
1 parent add69ab
commit 585268c
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 1 deletion.
diff --git a/src/ripple/core/Config.h b/src/ripple/core/Config.h
@@ -162,7 +162,7 @@ class Config : public BasicConfig
 
     std::string START_LEDGER;
 
-    std::optional<uint256> TRAP_TX_HASH = {};
+    std::optional<uint256> TRAP_TX_HASH;
 
     // Network parameters
     uint32_t NETWORK_ID = 0;

diff --git a/src/test/app/LedgerLoad_test.cpp b/src/test/app/LedgerLoad_test.cpp
@@ -254,6 +254,7 @@ class LedgerLoad_test : public beast::unit_test::suite
             beast::severities::kDisabled);
         auto const jrb = env.rpc("ledger", "current", "full")[jss::result];
         BEAST_EXPECT(jrb[jss::ledger][jss::accountState].size() == 97);
+        // in replace mode do not automatically accept the ledger being replayed
 
         env.close();
         auto const closed = env.rpc("ledger", "current", "full")[jss::result];
@@ -284,6 +285,7 @@ class LedgerLoad_test : public beast::unit_test::suite
             beast::severities::kDisabled);
         auto const jrb = env.rpc("ledger", "current", "full")[jss::result];
         BEAST_EXPECT(jrb[jss::ledger][jss::accountState].size() == 97);
+        // in replace mode do not automatically accept the ledger being replayed
 
         env.close();
         auto const closed = env.rpc("ledger", "current", "full")[jss::result];
@@ -304,6 +306,8 @@ class LedgerLoad_test : public beast::unit_test::suite
         boost::erase_all(ledgerHash, "\"");
         try
         {
+            // will throw an exception, because we cannot load a ledger for
+            // replay when trapTxHash is set to an invalid transaction
             Env env(
                 *this,
                 envconfig(