removed mptHolders (#43)

* removed unused declarations * comments
XRPLF · Oct 18, 2024 · 780af7a · 780af7a
1 parent f4bc120
commit 780af7a
Show file tree

Hide file tree

Showing 4 changed files with 10 additions and 7 deletions.
diff --git a/src/xrpld/rpc/MPTokenIssuanceID.h b/src/xrpld/rpc/MPTokenIssuanceID.h
@@ -32,6 +32,14 @@ namespace ripple {
 
 namespace RPC {
 
+/**
+   Add a `mpt_issuance_id` field to the `meta` input/output parameter.
+   The field is only added to successful MPTokenIssuanceCreate transactions.
+   The mpt_issuance_id is parsed from the sequence and the issuer in the
+   MPTokenIssuance object.
+
+   @{
+ */
 bool
 canHaveMPTokenIssuanceID(
     std::shared_ptr<STTx const> const& serializedTx,

diff --git a/src/xrpld/rpc/detail/MPTokenIssuanceID.cpp b/src/xrpld/rpc/detail/MPTokenIssuanceID.cpp
@@ -1,7 +1,7 @@
 //------------------------------------------------------------------------------
 /*
     This file is part of rippled: https://github.com/ripple/rippled
-    Copyright (c) 2023 Ripple Labs Inc.
+    Copyright (c) 2024 Ripple Labs Inc.
 
     Permission to use, copy, modify, and/or distribute this software for any
     purpose  with  or without fee is hereby granted, provided that the above
@@ -75,7 +75,7 @@ insertMPTokenIssuanceID(
         return;
 
     std::optional<uint192> result = getIDFromCreatedIssuance(transactionMeta);
-    if (result.has_value())
+    if (result)
         response[jss::mpt_issuance_id] = to_string(result.value());
 }
 

diff --git a/src/xrpld/rpc/detail/Tuning.h b/src/xrpld/rpc/detail/Tuning.h
@@ -57,9 +57,6 @@ static LimitRange constexpr accountNFTokens = {20, 100, 400};
 /** Limits for the nft_buy_offers & nft_sell_offers commands. */
 static LimitRange constexpr nftOffers = {50, 250, 500};
 
-/** Limits for the nft_buy_offers & nft_sell_offers commands. */
-static LimitRange constexpr mptHolders = {10, 200, 400};
-
 static int constexpr defaultAutoFillFeeMultiplier = 10;
 static int constexpr defaultAutoFillFeeDivisor = 1;
 static int constexpr maxPathfindsInProgress = 2;

diff --git a/src/xrpld/rpc/handlers/Handlers.h b/src/xrpld/rpc/handlers/Handlers.h
@@ -51,8 +51,6 @@ doBlackList(RPC::JsonContext&);
 Json::Value
 doCanDelete(RPC::JsonContext&);
 Json::Value
-doMPTHolders(RPC::JsonContext&);
-Json::Value
 doChannelAuthorize(RPC::JsonContext&);
 Json::Value
 doChannelVerify(RPC::JsonContext&);