Minor improvements

XRPLF · Nov 2, 2023 · b2a8a2d · b2a8a2d
1 parent 95b6055
commit b2a8a2d
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 1 deletion.
diff --git a/src/ripple/rpc/handlers/Tx.cpp b/src/ripple/rpc/handlers/Tx.cpp
@@ -344,6 +344,8 @@ populateJsonResponse(
                     context.apiVersion);
             }
 
+            // Note, result.ledgerHash is only set in a closed or validated
+            // ledger - as seen in `doTxHelp` and `doTxPostgres`
             if (result.ledgerHash)
                 response[jss::ledger_hash] = to_string(*result.ledgerHash);
 

diff --git a/src/test/rpc/TransactionEntry_test.cpp b/src/test/rpc/TransactionEntry_test.cpp
@@ -174,7 +174,7 @@ class TransactionEntry_test : public beast::unit_test::suite
                 BEAST_EXPECT(resIndex[jss::validated] == true);
                 BEAST_EXPECT(!resIndex[jss::tx_json].isMember(jss::Amount));
 
-                if (!close_time_iso.empty())
+                if (BEAST_EXPECT(!close_time_iso.empty()))
                     BEAST_EXPECT(
                         resIndex[jss::close_time_iso] == close_time_iso);
             }

diff --git a/src/test/rpc/Transaction_test.cpp b/src/test/rpc/Transaction_test.cpp
@@ -747,6 +747,11 @@ class Transaction_test : public beast::unit_test::suite
                 result[jss::result][jss::hash] ==
                 to_string(txn->getTransactionID()));
             BEAST_EXPECT(result[jss::result][jss::validated] == true);
+            BEAST_EXPECT(result[jss::result][jss::ledger_index] == 4);
+            BEAST_EXPECT(
+                result[jss::result][jss::ledger_hash] ==
+                "B41882E20F0EC6228417D28B9AE0F33833645D35F6799DFB782AC97FC4BB51"
+                "D2");
         }
 
         for (auto memberIt = expected.begin(); memberIt != expected.end();