Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add info about Websocket/RPC port(s) to the /crawl endpoint #2837

Closed
MarkusTeufelberger opened this issue Jan 25, 2019 · 2 comments · Fixed by #4427
Closed

Add info about Websocket/RPC port(s) to the /crawl endpoint #2837

MarkusTeufelberger opened this issue Jan 25, 2019 · 2 comments · Fixed by #4427
Assignees
@drlongle
Labels
API Change Feature Request Used to indicate requests to add new features Reviewed
Milestone
1.12

Comments

@MarkusTeufelberger
Copy link
Collaborator

As suggested in #2823, this could help in finding additional servers to use as a fallback for transaction submission for example. See also https://www.xrpchat.com/topic/30058-list-of-rippled-servers-with-wss-andor-json-rpc-servives/ for a need for this.

Currently there is no standard way to advertise these services, so the only other way to get this information would be to port-scan all reachable nodes. This is not a very friendly thing to do, having them advertise this in their /crawl endpoint is probably a better way forward.
@mDuo13 mDuo13 added API Change Feature Request Used to indicate requests to add new features labels Aug 2, 2019
@nbougalis nbougalis added the Good First Issue Great issue for a new contributor label Oct 21, 2020
@nbougalis
Copy link
Contributor

This would be nice to have. Anyone wanting to claim this issue, either assign yourself or raise your hand and I'll assign it to you :)

drlongle added a commit to drlongle/rippled that referenced this issue Feb 20, 2023
@drlongle
Add RPC/WS ports to server_info
e94932b 
Fix XRPLF#2837
@drlongle drlongle mentioned this issue Feb 20, 2023
Merged
7 tasks
drlongle added a commit to drlongle/rippled that referenced this issue Feb 20, 2023
@drlongle
Add RPC/WebSocket ports to server_info (XRPLF#4427)
e0ad966 
Fix XRPLF#2837.
drlongle added a commit to drlongle/rippled that referenced this issue Feb 20, 2023
@drlongle
Add RPC/WebSocket ports to server_info (XRPLF#4427)
41c3269 
Fix XRPLF#2837.
drlongle added a commit to drlongle/rippled that referenced this issue Feb 20, 2023
@drlongle
Add RPC/WebSocket ports to server_info (XRPLF#4427)
41198ea 
Fix XRPLF#2837.
drlongle added a commit to drlongle/rippled that referenced this issue Feb 23, 2023
@drlongle
Add RPC/WebSocket ports to server_info (XRPLF#4427)
1593d05 
Fix XRPLF#2837.
@intelliot
Copy link
Collaborator

will be fixed by #4427 - expected in 1.12

@intelliot intelliot added this to the 1.12 milestone May 25, 2023
@intelliot intelliot removed the Good First Issue Great issue for a new contributor label Jun 20, 2023
@github-project-automation github-project-automation bot moved this to 📋 Backlog in Core Ledger Jun 20, 2023
@intelliot intelliot moved this from 📋 Backlog to Hold for 1.12 in Core Ledger Jun 20, 2023
@intelliot intelliot moved this from Hold for 1.12 to 🛣 Ready to merge in Core Ledger Jun 21, 2023
intelliot pushed a commit that referenced this issue Jun 23, 2023
@drlongle
Add RPC/WS ports to server_info (#4427)
0b812cd 
Enhance the /crawl endpoint by publishing WebSocket/RPC ports in the
server_info response. The function processing requests to the /crawl
endpoint actually calls server_info internally, so this change enables a
server to advertise its WebSocket/RPC port(s) to peers via the /crawl
endpoint. `grpc` and `peer` ports are included as well.

The new `ports` array contains objects, each containing a `port` for the
listening port (number string), and an array `protocol` listing the
supported protocol(s).

This allows crawlers to build a richer topology without needing to
port-scan nodes. For non-admin users (including peers), the info about
*admin* ports is excluded.

Also increase test coverage for RPC ServerInfo.

Fix #2837.
@intelliot intelliot moved this from 🛣 Ready to merge to ✅ Merged in Core Ledger Jun 28, 2023
ckeshava pushed a commit to ckeshava/rippled that referenced this issue Jul 10, 2023
@drlongle @ckeshava
Add RPC/WS ports to server_info (XRPLF#4427)
5a7d35c 
Enhance the /crawl endpoint by publishing WebSocket/RPC ports in the
server_info response. The function processing requests to the /crawl
endpoint actually calls server_info internally, so this change enables a
server to advertise its WebSocket/RPC port(s) to peers via the /crawl
endpoint. `grpc` and `peer` ports are included as well.

The new `ports` array contains objects, each containing a `port` for the
listening port (number string), and an array `protocol` listing the
supported protocol(s).

This allows crawlers to build a richer topology without needing to
port-scan nodes. For non-admin users (including peers), the info about
*admin* ports is excluded.

Also increase test coverage for RPC ServerInfo.

Fix XRPLF#2837.
ckeshava pushed a commit to ckeshava/rippled that referenced this issue Sep 22, 2023
@drlongle @ckeshava
Add RPC/WS ports to server_info (XRPLF#4427)
a185d98 
Enhance the /crawl endpoint by publishing WebSocket/RPC ports in the
server_info response. The function processing requests to the /crawl
endpoint actually calls server_info internally, so this change enables a
server to advertise its WebSocket/RPC port(s) to peers via the /crawl
endpoint. `grpc` and `peer` ports are included as well.

The new `ports` array contains objects, each containing a `port` for the
listening port (number string), and an array `protocol` listing the
supported protocol(s).

This allows crawlers to build a richer topology without needing to
port-scan nodes. For non-admin users (including peers), the info about
*admin* ports is excluded.

Also increase test coverage for RPC ServerInfo.

Fix XRPLF#2837.
ckeshava pushed a commit to ckeshava/rippled that referenced this issue Sep 25, 2023
@drlongle @ckeshava
Add RPC/WS ports to server_info (XRPLF#4427)
c2723a8 
Enhance the /crawl endpoint by publishing WebSocket/RPC ports in the
server_info response. The function processing requests to the /crawl
endpoint actually calls server_info internally, so this change enables a
server to advertise its WebSocket/RPC port(s) to peers via the /crawl
endpoint. `grpc` and `peer` ports are included as well.

The new `ports` array contains objects, each containing a `port` for the
listening port (number string), and an array `protocol` listing the
supported protocol(s).

This allows crawlers to build a richer topology without needing to
port-scan nodes. For non-admin users (including peers), the info about
*admin* ports is excluded.

Also increase test coverage for RPC ServerInfo.

Fix XRPLF#2837.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@drlongle drlongle

Labels
API Change Feature Request Used to indicate requests to add new features Reviewed
Projects
Core Ledger
Archived in project
Milestone
1.12
Development

Successfully merging a pull request may close this issue.

Add RPC/WS ports to server_info drlongle/rippled
6 participants
@intelliot @MarkusTeufelberger @nbougalis @mDuo13 @carlhua @drlongle